From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79452-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1068 invoked by alias); 8 Mar 2011 19:41:16 -0000
Received: (qmail 1048 invoked by uid 22791); 8 Mar 2011 19:41:15 -0000
X-SWARE-Spam-Status: No, hits=-6.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Mar 2011 19:41:12 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p28Jf2EH029947	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 8 Mar 2011 14:41:02 -0500
Received: from greed.delorie.com (ovpn-113-35.phx2.redhat.com [10.3.113.35])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p28Jf1kK020233	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Tue, 8 Mar 2011 14:41:02 -0500
Received: from greed.delorie.com (localhost.localdomain [127.0.0.1])	by greed.delorie.com (8.14.4/8.14.4) with ESMTP id p28Jf0oj027042;	Tue, 8 Mar 2011 14:41:00 -0500
Received: (from dj@localhost)	by greed.delorie.com (8.14.4/8.14.4/Submit) id p28Jf0Uq027041;	Tue, 8 Mar 2011 14:41:00 -0500
Date: Tue, 08 Mar 2011 19:51:00 -0000
Message-Id: <201103081941.p28Jf0Uq027041@greed.delorie.com>
From: DJ Delorie <dj@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
CC: ktietz70@googlemail.com, binutils@sourceware.org,        gdb-patches@sourceware.org, gcc-patches@gcc.gnu.org
In-reply-to: <83aah5h34g.fsf@gnu.org> (message from Eli Zaretskii on Tue, 08	Mar 2011 20:35:27 +0200)
Subject: Re: [patch libiberty include]: Add additional helper functions for directory-separator searching
References: <AANLkTimyJb-3jEaWbbmUj2ZAOYPzhGT_GX9QFwR4DBCh@mail.gmail.com> <AANLkTi=WZtnE5sQ8oVHYUJ2fqOD7bPvsv3rr2y7Or-1e@mail.gmail.com> <AANLkTiksa6=7MWxeyDvgzBs89McAEgG12o+x41K02_OH@mail.gmail.com> <83aah5h34g.fsf@gnu.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00565.txt.bz2


> I think we don't need filename_dirchr, only filename_dirrchr.

I see no harm in having both, for completeness, though.  One could
argue they should be in separate files, but they're trivial functions
on non-dos-fs systems.

What bothers me about this patch is that we're adding yet another set
of functions that don't discriminate between the host filesystem, the
target filesystem, and the build filesystem.