From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19179 invoked by alias); 8 Mar 2011 18:58:52 -0000 Received: (qmail 19169 invoked by uid 22791); 8 Mar 2011 18:58:51 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Mar 2011 18:58:46 +0000 Received: (qmail 7202 invoked from network); 8 Mar 2011 18:58:45 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 8 Mar 2011 18:58:45 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] i386-tdep.c, check target_read_memory for error. Date: Tue, 08 Mar 2011 19:27:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.1; x86_64; ; ) Cc: Michael Snyder , Mark Kettenis , "jan.kratochvil@redhat.com" References: <4D715BB0.8030506@vmware.com> <201103072226.p27MQ8Zp004631@glazunov.sibelius.xs4all.nl> <4D767783.4090703@vmware.com> In-Reply-To: <4D767783.4090703@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103081858.43441.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00561.txt.bz2 On Tuesday 08 March 2011 18:37:55, Michael Snyder wrote: > @@ -1221,7 +1231,8 @@ i386_skip_noop (CORE_ADDR pc) > if (op == 0x90) > { > pc += 1; > - target_read_memory (pc, &op, 1); > + if (target_read_memory (pc, &op, 1)) > + return pc; I think you're meant to return PC as it was at function start. Note the pc += 1 above. There are other instances in the patch. -- Pedro Alves