Re: [RFA] dwarf2loc.c, loclist_read_variable, Assert frame not null

Michael Snyder
2011-03-05T00:12:03Z

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

Pedro Alves wrote:
> On Friday 04 March 2011 22:37:29, Michael Snyder wrote:
>> + gdb_asert (frame);
>
> Please make sure patches compile before posting them.
>

My bad.

Corrected patch attached.

[-- Attachment #2: null5.txt --]
[-- Type: text/plain, Size: 791 bytes --]

2011-03-04 Michael Snyder <msnyder@vmware.com>

* dwarf2loc.c (loclist_read_variable): Assert frame not null.

Index: dwarf2loc.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2loc.c,v
retrieving revision 1.110
diff -u -p -u -p -r1.110 dwarf2loc.c
--- dwarf2loc.c 27 Feb 2011 00:01:12 -0000 1.110
+++ dwarf2loc.c 4 Mar 2011 22:34:24 -0000
@@ -2687,8 +2687,11 @@ loclist_read_variable (struct symbol *sy
set_value_optimized_out (val, 1);
}
else
- val = dwarf2_evaluate_loc_desc (SYMBOL_TYPE (symbol), frame, data, size,
- dlbaton->per_cu);
+ {
+ gdb_assert (frame);
+ val = dwarf2_evaluate_loc_desc (SYMBOL_TYPE (symbol), frame,
+ data, size, dlbaton->per_cu);
+ }

return val;
}