From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10567 invoked by alias); 4 Mar 2011 21:29:44 -0000 Received: (qmail 10551 invoked by uid 22791); 4 Mar 2011 21:29:43 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 21:29:39 +0000 Received: (qmail 32475 invoked from network); 4 Mar 2011 21:29:38 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 4 Mar 2011 21:29:38 -0000 From: Pedro Alves To: Michael Snyder Subject: Re: [RFA] breakpoint.c, enable_command, missing break statement. Date: Fri, 04 Mar 2011 21:29:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.0; x86_64; ; ) Cc: "gdb-patches@sourceware.org" References: <4D713431.3060907@vmware.com> <201103041928.03380.pedro@codesourcery.com> <4D714472.6050404@vmware.com> In-Reply-To: <4D714472.6050404@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103042129.41681.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00328.txt.bz2 On Friday 04 March 2011 19:58:42, Michael Snyder wrote: > > It looks irrelevant. > > It's always relevant to document a fall-through. Sorry if I wasn't clear, bad choice of words, I guess. For avoidance of doubt, what I was trying to say was that it's the same thing whether we document that this case fallsthrough or whether we a break. > Agreed. Extending the same fix to disable_command, and committing. Thanks. -- Pedro Alves