From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3374 invoked by alias); 4 Mar 2011 19:38:11 -0000 Received: (qmail 3331 invoked by uid 22791); 4 Mar 2011 19:38:10 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 19:38:01 +0000 Received: (qmail 26979 invoked from network); 4 Mar 2011 19:38:00 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 4 Mar 2011 19:38:00 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: RFC: change "program exited" message Date: Fri, 04 Mar 2011 19:38:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.0; x86_64; ; ) Cc: Tom Tromey References: <201103041913.09385.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201103041938.02711.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00319.txt.bz2 On Friday 04 March 2011 19:23:03, Tom Tromey wrote: > >>>>> "Pedro" == Pedro Alves writes: > > Pedro> (Do we actually need gdb_continue_off_end? It seemed > Pedro> like in all but a couple of cases it was the same > Pedro> as gdb_continue_to_end, except that the new function > Pedro> doesn't handle using stubs.) > > I was not sure that this was safe to do. It is. You'd even be fixing testsuite hangs and timeouts for targets that require the stubs, as with those you'll never see the "exited normally" message. (I don't think I ever saw such a target though. Still.) > --- a/gdb/testsuite/gdb.base/langs.exp > +++ b/gdb/testsuite/gdb.base/langs.exp > @@ -146,8 +146,7 @@ if [runto csub] then { > gdb_breakpoint "exit" > gdb_test "cont" "Breakpoint .*exit.*" "continue to exit in langs.exp" > } else { > - gdb_test "cont" "Program exited normally\\..*" \ > - "continue to exit in langs.exp" > + gdb_continue_off_end > } > } > This whole if/then/else could be replaced with gdb_continue_to_end even, it looks like it's just like just an inlining of the same thing. > If you think it is ok, I can make that change. -- Pedro Alves