From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: gdb-patches@sourceware.org, brobecker@adacore.com
Subject: Re: [PATCH] fix spurious FAIL in py-inferior.exp (x86-solaris)
Date: Fri, 04 Mar 2011 12:18:00 -0000 [thread overview]
Message-ID: <201103041218.p24CI1vS028257@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <1299238268-32142-1-git-send-email-brobecker@adacore.com> (message from Joel Brobecker on Fri, 4 Mar 2011 15:31:08 +0400)
> From: Joel Brobecker <brobecker@adacore.com>
> Date: Fri, 4 Mar 2011 15:31:08 +0400
>
> The inferior is single-threaded, but on x86-solaris, GDB says
> that the program has two entries in the thread list:
>
> (gdb) info threads
> Id Target Id Frame
> * 2 Thread 1 (LWP 1) f2 (a=1) at /[...]/py-inferior.c:20
> 1 LWP 1 f2 (a=1) at /[...]/py-inferior.c:20
>
> As a result, the test that prints the list of threads trips
> because the expected output assumes only one thread.
That's a bug in the Solaris thread support. So...
> The regular expression I used to match is a little complicated because
> of the case where there is only one element -vs- the case where there
> is more than one. In the first case, the last element is followed by
> a comma. In the second case, it's not. I tried to make it easier
> to read by using a variable that factorizes the expression matching
> a thread object, as well as makes it shorter and easier to read.
...I think you should not adjust the testsuite for this.
next prev parent reply other threads:[~2011-03-04 12:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 11:31 Joel Brobecker
2011-03-04 12:18 ` Mark Kettenis [this message]
2011-03-04 12:27 ` Pedro Alves
2011-03-07 5:05 ` Joel Brobecker
2011-03-07 5:21 ` Jan Kratochvil
2011-03-07 10:52 ` Pedro Alves
2011-03-07 9:49 ` Mark Kettenis
2011-03-07 10:16 ` Joel Brobecker
2011-03-07 11:02 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103041218.p24CI1vS028257@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox