From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15892 invoked by alias); 3 Mar 2011 22:38:29 -0000 Received: (qmail 15883 invoked by uid 22791); 3 Mar 2011 22:38:28 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-pv0-f169.google.com (HELO mail-pv0-f169.google.com) (74.125.83.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 22:38:24 +0000 Received: by pvg4 with SMTP id 4so350411pvg.0 for ; Thu, 03 Mar 2011 14:38:23 -0800 (PST) Received: by 10.143.177.8 with SMTP id e8mr1242628wfp.320.1299191902808; Thu, 03 Mar 2011 14:38:22 -0800 (PST) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id w32sm2041620wfh.7.2011.03.03.14.38.16 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Mar 2011 14:38:18 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 18231170C1FA; Fri, 4 Mar 2011 09:08:12 +1030 (CST) Date: Thu, 03 Mar 2011 22:38:00 -0000 From: Alan Modra To: Michael Snyder Cc: Pedro Alves , "gdb-patches@sourceware.org" , "bug-binutils@gnu.org" Subject: Re: [RFA] peXXigen.c, _bfd_XXi_swap_aux_in, wrong size used in memcpy. Message-ID: <20110303223812.GR13094@bubble.grove.modra.org> Mail-Followup-To: Michael Snyder , Pedro Alves , "gdb-patches@sourceware.org" , "bug-binutils@gnu.org" References: <4D6FD940.7050400@vmware.com> <201103031913.20960.pedro@codesourcery.com> <4D6FF4B4.9090601@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D6FF4B4.9090601@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00229.txt.bz2 On Thu, Mar 03, 2011 at 12:06:12PM -0800, Michael Snyder wrote: > * peXXigen.c (_bfd_XXi_swap_aux_in): Use sizeof in memcpy. > (_bfd_XXi_swap_aux_out): Ditto. OK. The less code I have to look at to verify something is correct, the more I like it. -- Alan Modra Australia Development Lab, IBM