From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14879 invoked by alias); 3 Mar 2011 22:25:20 -0000 Received: (qmail 14871 invoked by uid 22791); 3 Mar 2011 22:25:20 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-pw0-f41.google.com (HELO mail-pw0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 22:25:15 +0000 Received: by pwi10 with SMTP id 10so405012pwi.0 for ; Thu, 03 Mar 2011 14:25:14 -0800 (PST) Received: by 10.142.203.12 with SMTP id a12mr1227543wfg.122.1299191114062; Thu, 03 Mar 2011 14:25:14 -0800 (PST) Received: from bubble.grove.modra.org ([115.187.252.19]) by mx.google.com with ESMTPS id d35sm2027893wfj.9.2011.03.03.14.25.10 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Mar 2011 14:25:13 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 7DE8E170C1FA; Fri, 4 Mar 2011 08:55:06 +1030 (CST) Date: Thu, 03 Mar 2011 22:25:00 -0000 From: Alan Modra To: Michael Snyder Cc: nickc@redhat.com, rth@redhat.com, bug-binutils@gnu.org, "gdb-patches@sourceware.org" Subject: Re: [RFA] archive.c, bsd_write_armap, fail if stat fails Message-ID: <20110303222506.GO13094@bubble.grove.modra.org> Mail-Followup-To: Michael Snyder , nickc@redhat.com, rth@redhat.com, bug-binutils@gnu.org, "gdb-patches@sourceware.org" References: <4D6FE1F1.1010501@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D6FE1F1.1010501@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00223.txt.bz2 On Thu, Mar 03, 2011 at 10:46:09AM -0800, Michael Snyder wrote: > * archive.c (bsd_write_armap): Fail if stat fails. I think it would be better to just set the timestamp to zero if stat fails. There is precedent for this, eg. opncls.c:_maybe_make_executable. -- Alan Modra Australia Development Lab, IBM