From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7497 invoked by alias); 3 Mar 2011 22:11:26 -0000 Received: (qmail 7484 invoked by uid 22791); 3 Mar 2011 22:11:25 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 22:11:23 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p23MBCPV019700 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 3 Mar 2011 17:11:12 -0500 Received: from greed.delorie.com (ovpn-113-35.phx2.redhat.com [10.3.113.35]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p23MBBqi031729 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Mar 2011 17:11:11 -0500 Received: from greed.delorie.com (localhost.localdomain [127.0.0.1]) by greed.delorie.com (8.14.4/8.14.4) with ESMTP id p23MB9FT003262; Thu, 3 Mar 2011 17:11:10 -0500 Received: (from dj@localhost) by greed.delorie.com (8.14.4/8.14.4/Submit) id p23MB9Ed003261; Thu, 3 Mar 2011 17:11:09 -0500 Date: Thu, 03 Mar 2011 22:11:00 -0000 Message-Id: <201103032211.p23MB9Ed003261@greed.delorie.com> From: DJ Delorie To: Michael Snyder CC: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org In-reply-to: <4D701056.1080208@vmware.com> (message from Michael Snyder on Thu, 03 Mar 2011 14:04:06 -0800) Subject: Re: [RFA] libiberty/hashtab.c, higher_prime_index: avoid array overrun References: <4D701056.1080208@vmware.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00219.txt.bz2 > As written, the function will access element [30] of a 30-element array. Um, no? unsigned int mid = low + (high - low) / 2; This can never give mid == high unless low == high, which won't happen in that loop. The math wants to search everything from (including) low to (excluding) high. (but I'm willing to be proven wrong...)