Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: Re: RFC: change "program exited" message
Date: Thu, 03 Mar 2011 21:20:00 -0000	[thread overview]
Message-ID: <201103032120.49764.pedro@codesourcery.com> (raw)
In-Reply-To: <m3ei6ovsf3.fsf@fleche.redhat.com>

Thanks for address this.  It's an overdue change.

On Thursday 03 March 2011 20:51:44, Tom Tromey wrote:
> This patch changes GDB to print:
> 
>     [Inferior 25036 exited normally]

That number is the PID, but "Inferior" should go with
GDB's inferior id, otherwise, it's quite confusing.

>     [Inferior 25036 exited normally]

I suggest, modelled on how we print threads:

"[Inferior " + inferior->num + "(" target_pid_to_string (pid_to_ptid (inf->pid)) + ")" + $whathappened + "]"

Should render on Linux as:

[Inferior 1 (process 25036) exited normally]

and against remote targets when gdb doesn't
know the target pid:

[Inferior 1 (Remote target) exited normally]

-- 
Pedro Alves


  parent reply	other threads:[~2011-03-03 21:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 20:52 Tom Tromey
2011-03-03 21:18 ` Michael Snyder
2011-03-03 21:20 ` Pedro Alves [this message]
2011-03-04  7:37   ` Eli Zaretskii
2011-03-04 17:24   ` Tom Tromey
2011-03-04 19:13     ` Pedro Alves
2011-03-04 19:23       ` Tom Tromey
2011-03-04 19:38         ` Pedro Alves
2011-03-07 16:17           ` Tom Tromey
2011-03-08  9:43             ` Regression: [Re: RFC: change "program exited" message] Jan Kratochvil
2011-03-08 15:11               ` Tom Tromey
2011-03-09 14:37                 ` Tom Tromey
2011-03-09 16:22                   ` Jan Kratochvil
2011-03-09 16:29                     ` Joel Brobecker
2011-03-09 17:28                     ` Tom Tromey
2011-03-09 17:32                       ` Jan Kratochvil
2011-03-09 18:15                         ` Tom Tromey
2011-03-09 18:22                           ` Jan Kratochvil
2011-03-09 18:58                             ` Tom Tromey
2011-03-04  9:12 ` RFC: change "program exited" message Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103032120.49764.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox