From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3432 invoked by alias); 3 Mar 2011 04:37:06 -0000 Received: (qmail 3316 invoked by uid 22791); 3 Mar 2011 04:37:05 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 04:37:02 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7856B2BADAD; Wed, 2 Mar 2011 23:37:00 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id PW68SMnR61BZ; Wed, 2 Mar 2011 23:37:00 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0CFB82BADAC; Wed, 2 Mar 2011 23:36:59 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id AA1531459AD; Thu, 3 Mar 2011 08:36:43 +0400 (RET) Date: Thu, 03 Mar 2011 04:37:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" , vinschen@redhat.com Subject: Re: [rfa] remote-fileio.c, remote_fileio_func_fstat, uninitialized st.st_ino. Message-ID: <20110303043643.GV30306@adacore.com> References: <4D6EBB4A.9080207@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D6EBB4A.9080207@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00156.txt.bz2 > 2011-03-02 Michael Snyder > > * remote-fileio.c (remote_fileio_func_fstat): Initialize st_ino > to zero. FWIW: The initialization is made for the case where the file descriptor is not a file, so we should be ablet to deduce that the st_ino (inode ID) is irrelevant and not used on the consumer side... This would suggest that your change is correct. (you should still wait for Corinna to comment) > Index: remote-fileio.c > =================================================================== > RCS file: /cvs/src/src/gdb/remote-fileio.c,v > retrieving revision 1.40 > diff -u -p -u -p -r1.40 remote-fileio.c > --- remote-fileio.c 25 Jan 2011 11:54:00 -0000 1.40 > +++ remote-fileio.c 2 Mar 2011 21:41:48 -0000 > @@ -1175,6 +1175,7 @@ remote_fileio_func_fstat (char *buf) > remote_fileio_to_fio_uint (1, fst.fst_dev); > st.st_mode = S_IFCHR | (fd == FIO_FD_CONSOLE_IN ? S_IRUSR : S_IWUSR); > st.st_nlink = 1; > + st.st_ino = 0; > #ifdef HAVE_GETUID > st.st_uid = getuid (); > #else -- Joel