From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16466 invoked by alias); 2 Mar 2011 18:04:05 -0000 Received: (qmail 16458 invoked by uid 22791); 2 Mar 2011 18:04:04 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Mar 2011 18:03:57 +0000 Received: (qmail 13652 invoked from network); 2 Mar 2011 18:03:55 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 2 Mar 2011 18:03:55 -0000 From: Pedro Alves To: Michael Snyder Subject: Re: [RFA] linux-nat.c, linux_thread_alive, user errno instead of err Date: Wed, 02 Mar 2011 18:04:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.0; x86_64; ; ) Cc: "gdb-patches@sourceware.org" , Mark Kettenis References: <4D6D8774.3090506@vmware.com> <201103020118.03628.pedro@codesourcery.com> <4D6E85EE.6090209@vmware.com> In-Reply-To: <4D6E85EE.6090209@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103021803.54297.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00111.txt.bz2 On Wednesday 02 March 2011 18:01:18, Michael Snyder wrote: > Pedro Alves wrote: > >>> --- linux-nat.c 1 Mar 2011 00:40:22 -0000 1.197 > >>> +++ linux-nat.c 1 Mar 2011 23:50:34 -0000 > >>> @@ -4045,7 +4045,7 @@ linux_thread_alive (ptid_t ptid) > >>> fprintf_unfiltered (gdb_stdlog, > >>> "LLTA: KILL(SIG0) %s (%s)\n", > >>> target_pid_to_str (ptid), > >>> - err ? safe_strerror (err) : "OK"); > >>> + err ? safe_strerror (errno) : "OK"); > > > > Not 100% correct. target_pid_to_str is allowed to > > clobber errno (as any function call is). > > OK. How about this then? That's it, thanks. -- Pedro Alves