From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1456 invoked by alias); 2 Mar 2011 04:27:09 -0000 Received: (qmail 1444 invoked by uid 22791); 2 Mar 2011 04:27:08 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Mar 2011 04:27:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4CE082BADA2; Tue, 1 Mar 2011 23:27:01 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lzLVRguhqaNP; Tue, 1 Mar 2011 23:27:01 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C2E422BAD99; Tue, 1 Mar 2011 23:27:00 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 691561459AD; Wed, 2 Mar 2011 08:26:46 +0400 (RET) Date: Wed, 02 Mar 2011 04:27:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [commit] record.c (record_restore): Check pointer before use. Message-ID: <20110302042646.GL30306@adacore.com> References: <4D6D564A.8080403@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D6D564A.8080403@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00081.txt.bz2 > 2011-03-01 Michael Snyder > > * reverse.c (record_restore): Move null-check to before pointer > dereference. > > Index: record.c > =================================================================== > RCS file: /cvs/src/src/gdb/record.c,v > retrieving revision 1.57 > diff -u -p -u -p -r1.57 record.c > --- record.c 10 Jan 2011 20:38:50 -0000 1.57 > +++ record.c 1 Mar 2011 20:23:33 -0000 > @@ -2214,12 +2214,12 @@ record_restore (void) > > /* Now need to find our special note section. */ > osec = bfd_get_section_by_name (core_bfd, "null0"); > + if (osec == NULL) > + return; > osec_size = bfd_section_size (core_bfd, osec); > if (record_debug) > fprintf_unfiltered (gdb_stdlog, "Find precord section %s.\n", > osec ? "succeeded" : "failed"); > - if (osec == NULL) > - return; I think that the debug trace ("Find precord section...") also needs to be moved up. -- Joel