From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, msnyder@vmware.com
Subject: Re: [RFA] linux-nat.c, linux_thread_alive, user errno instead of err
Date: Wed, 02 Mar 2011 01:18:00 -0000 [thread overview]
Message-ID: <201103020118.03628.pedro@codesourcery.com> (raw)
In-Reply-To: <201103020008.p2208ODO018859@glazunov.sibelius.xs4all.nl>
> > --- linux-nat.c 1 Mar 2011 00:40:22 -0000 1.197
> > +++ linux-nat.c 1 Mar 2011 23:50:34 -0000
> > @@ -4045,7 +4045,7 @@ linux_thread_alive (ptid_t ptid)
> > fprintf_unfiltered (gdb_stdlog,
> > "LLTA: KILL(SIG0) %s (%s)\n",
> > target_pid_to_str (ptid),
> > - err ? safe_strerror (err) : "OK");
> > + err ? safe_strerror (errno) : "OK");
Not 100% correct. target_pid_to_str is allowed to
clobber errno (as any function call is).
> >
> > if (err != 0)
> > return 0;
>
--
Pedro Alves
next prev parent reply other threads:[~2011-03-02 1:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 23:55 Michael Snyder
2011-03-02 0:09 ` Mark Kettenis
2011-03-02 1:18 ` Pedro Alves [this message]
2011-03-02 18:01 ` Michael Snyder
2011-03-02 18:04 ` Pedro Alves
2011-03-02 18:28 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103020118.03628.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox