From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1283 invoked by alias); 2 Mar 2011 02:23:09 -0000 Received: (qmail 1274 invoked by uid 22791); 2 Mar 2011 02:23:09 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Mar 2011 02:23:03 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 4FE941B40AA; Wed, 2 Mar 2011 02:23:01 +0000 (UTC) From: Mike Frysinger To: Pedro Alves Subject: Re: [PATCH v5] sim: bfin: new port Date: Wed, 02 Mar 2011 02:23:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.37; KDE/4.6.0; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201011152039.08285.vapier@gentoo.org> <201103011702.22120.vapier@gentoo.org> <201103020113.34913.pedro@codesourcery.com> In-Reply-To: <201103020113.34913.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2443028.mgbKJLoDHv"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201103012117.22736.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00079.txt.bz2 --nextPart2443028.mgbKJLoDHv Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-length: 2482 On Tuesday, March 01, 2011 20:13:34 Pedro Alves wrote: > On Tuesday 01 March 2011 22:02:21, Mike Frysinger wrote: > > On Tuesday, March 01, 2011 16:19:25 Pedro Alves wrote: > > > On Tuesday 22 February 2011 20:26:44, Mike Frysinger wrote: > > > > --- /dev/null > > > > +++ b/sim/bfin/linux-fixed-code.h > > > > @@ -0,0 +1,23 @@ > > > > +/* DO NOT EDIT: Autogenerated. */ > > > > +/* Fixed code region of Linux userspace starting at 0x400. Last > > > > produced + from Linux-2.6.37 (not that the fixed code region > > > > changes often). */ +static const unsigned char > > > > bfin_linux_fixed_code[] =3D { +0x28, 0xe1, 0xad, 0x00, 0xa0, 0x00, > > > > 0x00, 0x20, > > >=20 > > > (...) > > >=20 > > > > +0xa4, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > > > +}; > > >=20 > > > Now this kernel code in question was probably (haven't > > > checked) largely written by ADI, and as such ADI could > > > probably contribute a standalone version of its source > > > to the FSF under GPLv3, along with some script or makefile > > > that compiles it with a bfin-gcc and then generates > > > the blob array. Or you could write simple dumb > > > replacement implementations of the interface instead? > >=20 > > this code was written purely by ADI employees (2 or 3 of them to be > > exact), is written in pure Blackfin assembly, and we've explicitly > > licensed this file under GPLv2 or later. so i dont think this is an > > issue. it is not used by the kernel at all ... the code is placed in a > > fixed location for userspace binaries to call and is defined as part of > > the Blackfin ABI. see below. >=20 > Thanks. Since the Linux kernel is a mixture of code under GPLv2 > and `GPLv2 or later', the resulting compiled binary is GPLv2 > only (not later), so it's still an issue to dump from > the kernel binary. And I think only the interface is > defined as part of the ABI, not the implementation? >=20 > To comply with the GPL, we need to provide the source of > that blob. I guess it's easy to do what I suggested > above then? Then the GPLv2-only of the Linux kernel > won't apply, and we're all happy. i want to avoid gcc to avoid the chicken&egg issue. an .s should be fine=20 since gdb is in the same tree as the assembler (and this code doesnt really= =20 need CPP magic). but i'd like to avoid this step when possible, so how about including the=20 generated file too, and adding a makefile target so that it is regenerated= =20 whenever the .s changes ? -mike --nextPart2443028.mgbKJLoDHv Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJNbaiyAAoJEEFjO5/oN/WBiN4QAMDQEvEcsu5s3Qn5N4B6LHzp kzk2wMsUWO5pFA2gQoPMBq4cz368gBwLVElRHVf0+U2BEQittPgkbcDyXJ5vGBzA uJiozoJDwGvrTjHq/P4FixPKlnwHUhNnRO7cE5JrpfFAmlsdqp04asnrhU7NZrP6 Fhuo4dcrmXFMe1oVPPyMounxIGhTjh3xgFWkqeAijanKf1ycDAI5Bu4uyrD9nlce eM7svRwtp0syUO45DnxaQOCGbwNSZAtqgjjzHdjDtKaI73RCx/i9co5EoXShuiUR TFP6vdzvWLUHpLj60WotFgoRw9jWkD/66ti4IF9+Y0Cw8weFjESQFDtO8kOaJroJ DUwAiFBtUXRX+/lyuISaxdQLSw6OJB0u3xINZZDPeoM8xOATeFAxd8fZ+2Ng627J v00pkFeBgZpVURH4i9R1wNse76Rjc9QOaQnyOKrCUek6QrD7tdVfx+JfyzY8Wei/ WahtzjJdNc+p9SLDeASaDajhFlvVzCaZxCv69IxgIMQPnilzw+shYHU8dSrhUrb8 dn+7V9hFkFk8s6NTHm+Al5tY0/b5LHV0TpAnsBzv5uF5q91xq+D6/DuSvHLl8QR8 8ZiIYUeLmyddUjtW48ZYMENIfETOXKlWDLK378QmBIWVunFtfWy3sDa7AadVhXK+ vTmyc8rWVbYQDhAywB2Y =UKfR -----END PGP SIGNATURE----- --nextPart2443028.mgbKJLoDHv--