From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16086 invoked by alias); 1 Mar 2011 16:11:45 -0000 Received: (qmail 16072 invoked by uid 22791); 1 Mar 2011 16:11:39 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate7.uk.ibm.com (HELO mtagate7.uk.ibm.com) (194.196.100.167) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 16:11:33 +0000 Received: from d06nrmr1806.portsmouth.uk.ibm.com (d06nrmr1806.portsmouth.uk.ibm.com [9.149.39.193]) by mtagate7.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p21GBV7q002767 for ; Tue, 1 Mar 2011 16:11:31 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1806.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p21GBgCx1802262 for ; Tue, 1 Mar 2011 16:11:42 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p21GBUpL024528 for ; Tue, 1 Mar 2011 09:11:30 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p21GBTcR024525; Tue, 1 Mar 2011 09:11:29 -0700 Message-Id: <201103011611.p21GBTcR024525@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 01 Mar 2011 17:11:29 +0100 Subject: Re: [patch 2/3] Displaced stepping for 16-bit Thumb instructions To: yao@codesourcery.com (Yao Qi) Date: Tue, 01 Mar 2011 16:11:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <4D6CB5F0.4070203@codesourcery.com> from "Yao Qi" at Mar 01, 2011 05:01:36 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00031.txt.bz2 Yao Qi wrote: > * arm-tdep.h (struct displaced_step_closure): Add two new fields > is_thumb and insn_size. > * arm-tdep.c (displaced_read_reg): Adjust correct pipeline offset > on both ARM and Thumb mode. > (arm_process_displaced_insn): Set is_thumb and insn_size. > (arm_displaced_init_closure): Handle both 16-bit and 32-bit. > (arm_displaced_step_fixup): Likewise. This version is OK, thanks! Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com