From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25846 invoked by alias); 1 Mar 2011 09:07:47 -0000 Received: (qmail 25824 invoked by uid 22791); 1 Mar 2011 09:07:45 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,TW_CP,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Mar 2011 09:07:41 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p2197c8M021252; Tue, 1 Mar 2011 10:07:38 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p2197biT001306; Tue, 1 Mar 2011 10:07:37 +0100 (CET) Date: Tue, 01 Mar 2011 09:07:00 -0000 Message-Id: <201103010907.p2197biT001306@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: msnyder@vmware.com CC: gdb-patches@sourceware.org In-reply-to: <4D6C57B4.70807@vmware.com> (message from Michael Snyder on Mon, 28 Feb 2011 18:19:32 -0800) Subject: Re: [commit] breakpoint.c, breakpoint_adjustment_warning, make safe from overflow References: <4D6C57B4.70807@vmware.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00025.txt.bz2 > Date: Mon, 28 Feb 2011 18:19:32 -0800 > From: Michael Snyder > > checked in. Just wanted to say that there's lots of good stuff in this stream of patches, especially stuff like this where the reason for magic constants is also documented. Thanks Michael! > 2011-02-28 Michael Snyder > > * breakpoint.c (breakpoint_adjustment_warning): Make local char > buffers a little bigger, to avoid possibility of an overflow. > > Index: breakpoint.c > =================================================================== > RCS file: /cvs/src/src/gdb/breakpoint.c,v > retrieving revision 1.545 > diff -u -p -u -p -r1.545 breakpoint.c > --- breakpoint.c 28 Feb 2011 18:48:18 -0000 1.545 > +++ breakpoint.c 1 Mar 2011 02:15:05 -0000 > @@ -5504,8 +5504,10 @@ static void > breakpoint_adjustment_warning (CORE_ADDR from_addr, CORE_ADDR to_addr, > int bnum, int have_bnum) > { > - char astr1[40]; > - char astr2[40]; > + /* The longest string possibly returned by hex_string_custom > + is 50 chars. These must be at least that big for safety. */ > + char astr1[64]; > + char astr2[64]; > > strcpy (astr1, hex_string_custom ((unsigned long) from_addr, 8)); > strcpy (astr2, hex_string_custom ((unsigned long) to_addr, 8));