Re: [PATCH v3] sim: bfin: new port

Mike Frysinger
2011-02-22T17:56:33Z

[-- Attachment #1: Type: Text/Plain, Size: 1639 bytes --]

On Tuesday, February 22, 2011 05:04:19 Pedro Alves wrote:
> On Monday 21 February 2011 09:54:36, Joel Brobecker wrote:
> > Please, sending compressed files makes it harder to look at the file.
> > I think you were right to do it for a file that's 4MB, but in that case,
> > using something a little more usual like gz, zip or bzip2 would have
> > made things easier... I had to install the xzutil on my laptop and it
> > wasn't without its little scary moment...
> >
> > > changes since v3:
> > > - stubbed all the bootroms
>
> Did you send the correct patch? I still see a bunch of:
> > diff --git a/sim/bfin/bfroms/bf50x-0.0.h b/sim/bfin/bfroms/bf50x-0.0.h
> > new file mode 100644
> > index 0000000..8d88c73
> > --- /dev/null
> > +++ b/sim/bfin/bfroms/bf50x-0.0.h
> > @@ -0,0 +1,515 @@
> > +/* DO NOT EDIT: Autogenerated. */
> > +static const char bfrom_bf50x_0_0[] = {

but they're all empty stubs:
foo[] = {};

this allows the sim to at least generate a region of NOPs, and makes it easier
for when i merge back in.

> > +#! /bin/sh
> > +# Guess values for system-dependent variables and create Makefiles.
> > +# Generated by GNU Autoconf 2.68.
>
> The whole tree is at Autoconf 2.64. Please use that version.

np

> Preferably, a pristine FSF version, as distros tend to patch
> autoconf, and that causes churn on the output.

Gentoo does not apply patches to 2.64. installing any autotool package by
hand outside of the PM is a pita ...

this is generally why i keep old autoconf/automake versions in the Gentoo
tree. so i can easily downgrade for old FSF projects ;).
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]