Re: [PATCH v3] sim: bfin: new port

Pedro Alves
2011-02-22T18:07:13Z

On Tuesday 22 February 2011 17:56:23, Mike Frysinger wrote:
> On Tuesday, February 22, 2011 05:04:19 Pedro Alves wrote:
> > > Mike Frysinger wrote:
> > > > changes since v3:
> > > > - stubbed all the bootroms
> > >
> > Did you send the correct patch? I still see a bunch of:
> > > diff --git a/sim/bfin/bfroms/bf50x-0.0.h b/sim/bfin/bfroms/bf50x-0.0.h
> > > new file mode 100644
> > > index 0000000..8d88c73
> > > --- /dev/null
> > > +++ b/sim/bfin/bfroms/bf50x-0.0.h
> > > @@ -0,0 +1,515 @@
> > > +/* DO NOT EDIT: Autogenerated. */
> > > +static const char bfrom_bf50x_0_0[] = {
>
> but they're all empty stubs:
> foo[] = {};
>

Hmm. That's not what I see on the patch from
<http://sourceware.org/ml/gdb-patches/2011-02/msg00517.html>:

diff --git a/sim/bfin/bfroms/bf50x-0.0.h b/sim/bfin/bfroms/bf50x-0.0.h
new file mode 100644
index 0000000..8d88c73
--- /dev/null
+++ b/sim/bfin/bfroms/bf50x-0.0.h
@@ -0,0 +1,515 @@
+/* DO NOT EDIT: Autogenerated. */
+static const char bfrom_bf50x_0_0[] = {
+0x40, 0x20, 0x2a, 0x20, 0x49, 0x23, 0x09, 0x23,
+0xf8, 0x25, 0xa7, 0x24, 0x33, 0x20, 0x32, 0x20,
+0x31, 0x20, 0x30, 0x20, 0x2f, 0x20, 0x2e, 0x20,
+0x2d, 0x20, 0x24, 0x20, 0x2b, 0x20, 0x2a, 0x20,
+0x54, 0x21, 0x99, 0x23, 0x00, 0x20, 0x00, 0x20,
+0x00, 0x20, 0xdb, 0x20, 0x25, 0x00, 0x24, 0x00,
+0x26, 0x27, 0x44, 0x27, 0x59, 0x27, 0x81, 0x27,
+0xce, 0x23, 0x27, 0x26, 0x90, 0x26, 0x23, 0x00,

I downloaded the file with wget, and xz -d'd it manually,
to make sure I wasn't hitting some cache weirdness in
my kde/ark desktop.

Am I looking at the right file?

--
Pedro Alves