Re: [PATCH v3] sim: bfin: new port

Pedro Alves
2011-02-22T10:04:33Z

On Monday 21 February 2011 09:54:36, Joel Brobecker wrote:
> Please, sending compressed files makes it harder to look at the file.
> I think you were right to do it for a file that's 4MB, but in that case,
> using something a little more usual like gz, zip or bzip2 would have
> made things easier... I had to install the xzutil on my laptop and it
> wasn't without its little scary moment...
>
> > changes since v3:
> > - stubbed all the bootroms

Did you send the correct patch? I still see a bunch of:

> diff --git a/sim/bfin/bfroms/bf50x-0.0.h b/sim/bfin/bfroms/bf50x-0.0.h
> new file mode 100644
> index 0000000..8d88c73
> --- /dev/null
> +++ b/sim/bfin/bfroms/bf50x-0.0.h
> @@ -0,0 +1,515 @@
> +/* DO NOT EDIT: Autogenerated. */
> +static const char bfrom_bf50x_0_0[] = {

> (i'll follow up)

Thanks, I do hope this is sorted out.

> I have no other comment. I think you know what you're doing in
> the simulator area, so I'm inclined to trust your judgment on
> the rest of the code (if you could just remember for future
> contributions that comments are important).

> If Pedro has no further comments, the meat of the patch is OK with me.

One:

> +#! /bin/sh
> +# Guess values for system-dependent variables and create Makefiles.
> +# Generated by GNU Autoconf 2.68.

The whole tree is at Autoconf 2.64. Please use that version.
Preferably, a pristine FSF version, as distros tend to patch
autoconf, and that causes churn on the output.

I'll reply to another email, but other than that I have further
comments. Thanks.

--
Pedro Alves