From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: gdb-patches@sourceware.org
Cc: pedro@codesourcery.com (Pedro Alves),
bauerman@br.ibm.com (Thiago Jung Bauermann)
Subject: [commit] Remove unused parameter (Re: [rfc] More intelligent indenting of multi-line table entries)
Date: Mon, 28 Feb 2011 16:34:00 -0000 [thread overview]
Message-ID: <201102281624.p1SGO3Tx029386@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <201102281523.p1SFNDdE022526@d06av02.portsmouth.uk.ibm.com> from "Ulrich Weigand" at Feb 28, 2011 04:23:13 PM
Hello,
I've checked in the following patch as well. The PRINT_ADDRESS_BITS
parameter is now unused in print_one_breakpoint_location and therefore
print_one_breakpoint, so it should be removed.
Bye,
Ulrich
ChangeLog:
* breakpoint.c (print_one_breakpoint_location): Remove unused
argument PRINT_ADDRESS_BITS. Update callers.
(print_one_breakpoint): Likewise.
Index: gdb/breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.543
diff -u -p -r1.543 breakpoint.c
--- gdb/breakpoint.c 28 Feb 2011 15:21:21 -0000 1.543
+++ gdb/breakpoint.c 28 Feb 2011 16:17:16 -0000
@@ -4708,7 +4708,6 @@ print_one_breakpoint_location (struct br
struct bp_location *loc,
int loc_number,
struct bp_location **last_loc,
- int print_address_bits,
int allflag)
{
struct command_line *l;
@@ -4999,11 +4998,9 @@ print_one_breakpoint_location (struct br
static void
print_one_breakpoint (struct breakpoint *b,
struct bp_location **last_loc,
- int print_address_bits,
int allflag)
{
- print_one_breakpoint_location (b, NULL, 0, last_loc,
- print_address_bits, allflag);
+ print_one_breakpoint_location (b, NULL, 0, last_loc, allflag);
/* If this breakpoint has custom print function,
it's already printed. Otherwise, print individual
@@ -5025,8 +5022,7 @@ print_one_breakpoint (struct breakpoint
struct bp_location *loc;
int n = 1;
for (loc = b->loc; loc; loc = loc->next, ++n)
- print_one_breakpoint_location (b, loc, n, last_loc,
- print_address_bits, allflag);
+ print_one_breakpoint_location (b, loc, n, last_loc, allflag);
}
}
}
@@ -5070,9 +5066,7 @@ do_captured_breakpoint_query (struct ui_
{
if (args->bnum == b->number)
{
- int print_address_bits = breakpoint_address_bits (b);
-
- print_one_breakpoint (b, &dummy_loc, print_address_bits, 0);
+ print_one_breakpoint (b, &dummy_loc, 0);
return GDB_RC_OK;
}
}
@@ -5243,7 +5237,7 @@ breakpoint_1 (char *args, int allflag,
/* We only print out user settable breakpoints unless the
allflag is set. */
if (allflag || user_breakpoint_p (b))
- print_one_breakpoint (b, &last_loc, print_address_bits, allflag);
+ print_one_breakpoint (b, &last_loc, allflag);
}
do_cleanups (bkpttbl_chain);
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2011-02-28 16:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 1:54 [RFA] Implement support for PowerPC BookE ranged breakpoints Thiago Jung Bauermann
2011-01-28 9:39 ` Eli Zaretskii
2011-01-31 19:07 ` Thiago Jung Bauermann
2011-01-31 20:39 ` Eli Zaretskii
2011-02-17 15:49 ` Ulrich Weigand
2011-02-23 20:50 ` Thiago Jung Bauermann
2011-02-24 20:45 ` [rfc] More intelligent indenting of multi-line table entries (Re: [RFA] Implement support for PowerPC BookE ranged breakpoints) Ulrich Weigand
2011-02-25 14:46 ` Pedro Alves
2011-02-28 15:33 ` [rfc] More intelligent indenting of multi-line table entries (Re: [RFA] Implement support for PowerPC BookE ranged breakpoin Ulrich Weigand
2011-02-28 16:34 ` Ulrich Weigand [this message]
2011-02-25 15:33 ` [rfc] More intelligent indenting of multi-line table entries (Re: [RFA] Implement support for PowerPC BookE ranged breakpoints) Thiago Jung Bauermann
2011-02-28 17:08 ` [RFA] Implement support for PowerPC BookE ranged breakpoints Ulrich Weigand
2011-03-12 2:03 ` Thiago Jung Bauermann
2011-03-12 16:44 ` Thiago Jung Bauermann
2011-03-14 20:50 ` Ulrich Weigand
2011-03-16 6:07 ` Thiago Jung Bauermann
2011-03-16 18:00 ` Ulrich Weigand
2011-03-14 21:02 ` Ulrich Weigand
2011-03-28 16:50 ` Thiago Jung Bauermann
2011-03-29 13:10 ` Ulrich Weigand
2011-03-31 15:41 ` Thiago Jung Bauermann
2011-03-31 16:04 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102281624.p1SGO3Tx029386@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox