From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28228 invoked by alias); 28 Feb 2011 04:57:53 -0000 Received: (qmail 28212 invoked by uid 22791); 28 Feb 2011 04:57:52 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Feb 2011 04:57:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 30AE12BAFB4; Sun, 27 Feb 2011 23:57:47 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ySf5qXTdWU-5; Sun, 27 Feb 2011 23:57:47 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BA7802BAFB2; Sun, 27 Feb 2011 23:57:46 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 6621B145A56; Mon, 28 Feb 2011 08:57:35 +0400 (RET) Date: Mon, 28 Feb 2011 05:01:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: [RFC] Compile GDB with -Wshadow? (was: "Re: [rfa] function parameter shadowed by local variable in opencl-lang.c") Message-ID: <20110228045735.GD30306@adacore.com> References: <4D698B92.3070309@vmware.com> <4D698C33.9040101@vmware.com> <20110228045225.GC30306@adacore.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Dxnq1zWXvFF0Q93v" Content-Disposition: inline In-Reply-To: <20110228045225.GC30306@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00877.txt.bz2 --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 388 > I wish the compiler would warn us about things like this... The patch > looks correct to me, but I will let Ken and Ulrich take a look. Perhaps > they'll be able to suggest a more specific name than `length2' ;-). Howzabout we add -Wshadow to the list of warning compiler switches for GCC? Something like this (untested for now, just to give an idea for this discussion)... -- Joel --Dxnq1zWXvFF0Q93v Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="wshadow.diff" Content-length: 496 diff --git a/gdb/configure.ac b/gdb/configure.ac index f31ef2a..ea0cda9 100644 --- a/gdb/configure.ac +++ b/gdb/configure.ac @@ -1753,7 +1753,7 @@ fi build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wformat-nonliteral -Wno-pointer-sign \ -Wno-unused -Wunused-value -Wunused-function \ --Wno-switch -Wno-char-subscripts" +-Wno-switch -Wno-char-subscripts -Wshadow" # Enable -Wno-format by default when using gcc on mingw since many # GCC versions complain about %I64. --Dxnq1zWXvFF0Q93v--