From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-78807-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24985 invoked by alias); 28 Feb 2011 04:47:26 -0000
Received: (qmail 24977 invoked by uid 22791); 28 Feb 2011 04:47:26 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Feb 2011 04:47:19 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id DF8422BAFD9;	Sun, 27 Feb 2011 23:47:17 -0500 (EST)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id lEV5Qupr0tdB; Sun, 27 Feb 2011 23:47:17 -0500 (EST)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id 7821D2BAFA5;	Sun, 27 Feb 2011 23:47:17 -0500 (EST)
Received: by joel.gnat.com (Postfix, from userid 1000)	id B22FD145A56; Mon, 28 Feb 2011 08:47:05 +0400 (RET)
Date: Mon, 28 Feb 2011 04:50:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] is_name_suffix("") is always non-zero
Message-ID: <20110228044705.GB30306@adacore.com>
References: <m27hcmsapy.fsf@igel.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m27hcmsapy.fsf@igel.home>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00874.txt.bz2

> 2011-02-26  Andreas Schwab  <schwab@linux-m68k.org>
> 
> 	* ada-lang.c (compare_names): Call is_name_suffix with string1
> 	instead of string2.

Thanks for spotting that.  Was this from code inspection, or did you
hit a bug?

Your patch does look correct to me. But the implementation of that
function is a little obscure to me - I suspect that this is because
it is meant to work in contexts other than Ada. So I asked Paul
to review your patch for me.

-- 
Joel