From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14256 invoked by alias); 27 Feb 2011 17:13:17 -0000 Received: (qmail 14247 invoked by uid 22791); 27 Feb 2011 17:13:16 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_RG,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 27 Feb 2011 17:13:06 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1RHD530020093 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 27 Feb 2011 12:13:05 -0500 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p1RHD2lr031855 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 27 Feb 2011 12:13:04 -0500 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p1RHD2ue018088; Sun, 27 Feb 2011 18:13:02 +0100 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id p1RHD17P018087; Sun, 27 Feb 2011 18:13:01 +0100 Date: Sun, 27 Feb 2011 20:35:00 -0000 From: Jan Kratochvil To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [rfa] add_symbol_file_command, avoid memory leak. Message-ID: <20110227171301.GA16297@host1.dyn.jankratochvil.net> References: <4D69AAFC.6030607@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D69AAFC.6030607@vmware.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00837.txt.bz2 On Sun, 27 Feb 2011 02:38:04 +0100, Michael Snyder wrote: > This looks straightforward, but I'd appreciate review. > I don't really understand why sect_opts never gets freed? It is a bug, sect_opts should be freed. It is last time used by the lines: char *val = sect_opts[i].value; char *sec = sect_opts[i].name; The strings in sect_opts[i].name are last time used there by: symbol_file_add (filename, from_tty ? SYMFILE_VERBOSE : 0, section_addrs, flags); This is also the reason why the NAMEs do not have strdup() and they get safely freed through make_cleanup_freeargv there. > --- symfile.c 26 Feb 2011 02:07:09 -0000 1.307 > +++ symfile.c 27 Feb 2011 01:35:32 -0000 > @@ -2169,15 +2169,15 @@ add_symbol_file_command (char *args, int > size_t num_sect_opts = 0; > struct cleanup *my_cleanups = make_cleanup (null_cleanup, NULL); > > + if (args == NULL) > + error (_("add-symbol-file takes a file name and an address")); > + > num_sect_opts = 16; > sect_opts = (struct sect_opt *) xmalloc (num_sect_opts > * sizeof (struct sect_opt)); > > dont_repeat (); > > - if (args == NULL) > - error (_("add-symbol-file takes a file name and an address")); > - > argv = gdb_buildargv (args); > make_cleanup_freeargv (argv); > While a nitpick it is a regression, that dont_repeat should be called even in the case of that error. Thanks, Jan