From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Michael Snyder <msnyder@vmware.com>, Doug Evans <dje@google.com>
Subject: Re: [RFA] off by one array reference in i386-low.c/i386_show_dr
Date: Sun, 27 Feb 2011 17:01:00 -0000 [thread overview]
Message-ID: <201102271655.15841.pedro@codesourcery.com> (raw)
In-Reply-To: <4D698427.2050301@vmware.com>
On Saturday 26 February 2011 22:52:23, Michael Snyder wrote:
> I'm not 100 percent sure this is right, but I do know that
> as written, it will overflow the array dr_mirror.
How? 'i' is incremented twice on each iteration.
> Index: i386-low.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbserver/i386-low.c,v
> retrieving revision 1.5
> diff -u -p -u -p -r1.5 i386-low.c
> --- i386-low.c 1 Jan 2011 15:33:24 -0000 1.5
> +++ i386-low.c 26 Feb 2011 22:48:38 -0000
> @@ -195,7 +195,7 @@ i386_show_dr (struct i386_debug_reg_stat
> \tDR%d: addr=0x%s, ref.count=%d DR%d: addr=0x%s, ref.count=%d\n",
> i, paddress (state->dr_mirror[i]),
> state->dr_ref_count[i],
> - i + 1, paddress (state->dr_mirror[i + 1]),
> + i + 1, paddress (state->dr_mirror[i]),
> state->dr_ref_count[i + 1]);
Even if there's chance of overflow that I'm not
seeing, this change is obviously wrong.
> i++;
> }
--
Pedro Alves
prev parent reply other threads:[~2011-02-27 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 23:24 Michael Snyder
2011-02-27 16:47 ` Jan Kratochvil
2011-02-27 21:33 ` Michael Snyder
2011-02-27 21:41 ` Jan Kratochvil
2011-02-27 21:50 ` Mark Kettenis
2011-02-27 22:05 ` Michael Snyder
2011-02-27 17:01 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102271655.15841.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox