From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-78742-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20490 invoked by alias); 26 Feb 2011 22:31:24 -0000
Received: (qmail 20482 invoked by uid 22791); 26 Feb 2011 22:31:23 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 26 Feb 2011 22:31:18 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p1QMVDhT003748;	Sat, 26 Feb 2011 23:31:13 +0100 (CET)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p1QMVCbB011727;	Sat, 26 Feb 2011 23:31:12 +0100 (CET)
Date: Sat, 26 Feb 2011 22:40:00 -0000
Message-Id: <201102262231.p1QMVCbB011727@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: msnyder@vmware.com
CC: gdb-patches@sourceware.org
In-reply-to: <4D697612.9050507@vmware.com> (message from Michael Snyder on	Sat, 26 Feb 2011 13:52:18 -0800)
Subject: Re: [commit] Document that case statement fall-through is intentional.
References:  <4D697612.9050507@vmware.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00809.txt.bz2

> Date: Sat, 26 Feb 2011 13:52:18 -0800
> From: Michael Snyder <msnyder@vmware.com>
> 
> Tested with "set debug expression 1" -- and I'm telling you, it took me
> a while to figure THAT out!
> 
> 
> --------------070307060603090205010008
> Content-Type: text/plain;
>  name="dump.txt"
> Content-Transfer-Encoding: 7bit
> Content-Disposition: inline;
>  filename="dump.txt"
> 
> 2011-02-26  Michael Snyder  <msnyder@vmware.com>
> 
> 	* expprint.c (dump_subexp_body_standard): Document that case
> 	statement is meant to fall through.
> 
> Index: expprint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/expprint.c,v
> retrieving revision 1.50
> diff -u -p -u -p -r1.50 expprint.c
> --- expprint.c	1 Feb 2011 18:56:34 -0000	1.50
> +++ expprint.c	26 Feb 2011 21:48:49 -0000
> @@ -767,6 +767,7 @@ dump_subexp_body_standard (struct expres
>      case TERNOP_SLICE:
>      case TERNOP_SLICE_COUNT:
>        elt = dump_subexp (exp, stream, elt);
> +      /* FALL THROUGH */

proper spelling is /* FALLTHROUGH */, at least that's what the classic
lint tool wants.