From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2348 invoked by alias); 22 Feb 2011 18:07:13 -0000 Received: (qmail 2335 invoked by uid 22791); 22 Feb 2011 18:07:12 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Feb 2011 18:07:07 +0000 Received: (qmail 31001 invoked from network); 22 Feb 2011 18:07:06 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Feb 2011 18:07:06 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH v3] sim: bfin: new port Date: Tue, 22 Feb 2011 18:25:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.6.0; x86_64; ; ) Cc: Mike Frysinger , Joel Brobecker References: <201011152039.08285.vapier@gentoo.org> <201102221004.19755.pedro@codesourcery.com> <201102221256.24685.vapier@gentoo.org> In-Reply-To: <201102221256.24685.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201102221806.59014.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00606.txt.bz2 On Tuesday 22 February 2011 17:56:23, Mike Frysinger wrote: > On Tuesday, February 22, 2011 05:04:19 Pedro Alves wrote: > > > Mike Frysinger wrote: > > > > changes since v3: > > > > - stubbed all the bootroms > > > > > Did you send the correct patch? I still see a bunch of: > > > diff --git a/sim/bfin/bfroms/bf50x-0.0.h b/sim/bfin/bfroms/bf50x-0.0.h > > > new file mode 100644 > > > index 0000000..8d88c73 > > > --- /dev/null > > > +++ b/sim/bfin/bfroms/bf50x-0.0.h > > > @@ -0,0 +1,515 @@ > > > +/* DO NOT EDIT: Autogenerated. */ > > > +static const char bfrom_bf50x_0_0[] = { > > but they're all empty stubs: > foo[] = {}; > Hmm. That's not what I see on the patch from : diff --git a/sim/bfin/bfroms/bf50x-0.0.h b/sim/bfin/bfroms/bf50x-0.0.h new file mode 100644 index 0000000..8d88c73 --- /dev/null +++ b/sim/bfin/bfroms/bf50x-0.0.h @@ -0,0 +1,515 @@ +/* DO NOT EDIT: Autogenerated. */ +static const char bfrom_bf50x_0_0[] = { +0x40, 0x20, 0x2a, 0x20, 0x49, 0x23, 0x09, 0x23, +0xf8, 0x25, 0xa7, 0x24, 0x33, 0x20, 0x32, 0x20, +0x31, 0x20, 0x30, 0x20, 0x2f, 0x20, 0x2e, 0x20, +0x2d, 0x20, 0x24, 0x20, 0x2b, 0x20, 0x2a, 0x20, +0x54, 0x21, 0x99, 0x23, 0x00, 0x20, 0x00, 0x20, +0x00, 0x20, 0xdb, 0x20, 0x25, 0x00, 0x24, 0x00, +0x26, 0x27, 0x44, 0x27, 0x59, 0x27, 0x81, 0x27, +0xce, 0x23, 0x27, 0x26, 0x90, 0x26, 0x23, 0x00, I downloaded the file with wget, and xz -d'd it manually, to make sure I wasn't hitting some cache weirdness in my kde/ark desktop. Am I looking at the right file? -- Pedro Alves