From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28086 invoked by alias); 22 Feb 2011 10:04:33 -0000 Received: (qmail 28073 invoked by uid 22791); 22 Feb 2011 10:04:32 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,TW_XZ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Feb 2011 10:04:25 +0000 Received: (qmail 13010 invoked from network); 22 Feb 2011 10:04:23 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Feb 2011 10:04:23 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH v3] sim: bfin: new port Date: Tue, 22 Feb 2011 10:08:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.6.0; x86_64; ; ) Cc: Joel Brobecker , Mike Frysinger References: <201011152039.08285.vapier@gentoo.org> <20110221095436.GD2600@adacore.com> In-Reply-To: <20110221095436.GD2600@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201102221004.19755.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00577.txt.bz2 On Monday 21 February 2011 09:54:36, Joel Brobecker wrote: > Please, sending compressed files makes it harder to look at the file. > I think you were right to do it for a file that's 4MB, but in that case, > using something a little more usual like gz, zip or bzip2 would have > made things easier... I had to install the xzutil on my laptop and it > wasn't without its little scary moment... > > > changes since v3: > > - stubbed all the bootroms Did you send the correct patch? I still see a bunch of: > diff --git a/sim/bfin/bfroms/bf50x-0.0.h b/sim/bfin/bfroms/bf50x-0.0.h > new file mode 100644 > index 0000000..8d88c73 > --- /dev/null > +++ b/sim/bfin/bfroms/bf50x-0.0.h > @@ -0,0 +1,515 @@ > +/* DO NOT EDIT: Autogenerated. */ > +static const char bfrom_bf50x_0_0[] = { > (i'll follow up) Thanks, I do hope this is sorted out. > I have no other comment. I think you know what you're doing in > the simulator area, so I'm inclined to trust your judgment on > the rest of the code (if you could just remember for future > contributions that comments are important). > If Pedro has no further comments, the meat of the patch is OK with me. One: > +#! /bin/sh > +# Guess values for system-dependent variables and create Makefiles. > +# Generated by GNU Autoconf 2.68. The whole tree is at Autoconf 2.64. Please use that version. Preferably, a pristine FSF version, as distros tend to patch autoconf, and that causes churn on the output. I'll reply to another email, but other than that I have further comments. Thanks. -- Pedro Alves