From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10096 invoked by alias); 22 Feb 2011 08:28:01 -0000 Received: (qmail 10087 invoked by uid 22791); 22 Feb 2011 08:28:01 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Feb 2011 08:27:57 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9326C2BAB29; Tue, 22 Feb 2011 03:27:55 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id n3Bmq1t5Ko11; Tue, 22 Feb 2011 03:27:55 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 057132BAB24; Tue, 22 Feb 2011 03:27:54 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id CCB001459B0; Tue, 22 Feb 2011 12:27:47 +0400 (RET) Date: Tue, 22 Feb 2011 08:51:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: Tom Tromey , "gdb-patches@sourceware.org" , Vladimir Prus , "dan@codesourcery.com" Subject: Re: [RFA] add test for memattr, use get_number_or_range for memattr commands Message-ID: <20110222082747.GQ2600@adacore.com> References: <4D605267.8030708@vmware.com> <20110221091304.GB2600@adacore.com> <4D62EE87.6040902@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D62EE87.6040902@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00573.txt.bz2 > 2011-02-21 Michael Snyder > > * memattr.c (mem_enable_command): Use get_number_or_range. > (mem_disable_command): Ditto. > (mem_delete_command): Ditto. > (_initialize_mem): Tweak usage message to reflect multiple > arguments. > > 2011-02-21 Michael Snyder > > * gdb.base/memattr.exp: New test. > * gdb.base/memattr.c: Test load for memattr.exp. Overall, the patch looks OK to me. > +gdb_test_multiple "info address mem1" "get address of mem1" { > + -re "Symbol \"mem1\" is static storage at address ($hex).*$gdb_prompt $" { > + set mem1start $expect_out(1,string) > + } > +} [...] > +gdb_test_no_output "mem $mem1start $mem1end wo" "create mem region 1" I still think that, if the first quoted test does not pass, the second will cause the testcase to crash because mem1start is going to be undefined. This is what you're going to see when that happens: ERROR: tcl error sourcing /[...]/memattr.exp ERROR: can't read "mem1start": no such variable while executing "gdb_test_no_output "mem $mem1start $mem1end wo" "create mem region 1"" But I'm OK with that, if that's OK with the others. -- Joel