From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2210 invoked by alias); 21 Feb 2011 15:08:34 -0000 Received: (qmail 2201 invoked by uid 22791); 21 Feb 2011 15:08:33 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate2.uk.ibm.com (HELO mtagate2.uk.ibm.com) (194.196.100.162) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Feb 2011 15:08:27 +0000 Received: from d06nrmr1307.portsmouth.uk.ibm.com (d06nrmr1307.portsmouth.uk.ibm.com [9.149.38.129]) by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p1LF8NVw030984 for ; Mon, 21 Feb 2011 15:08:23 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p1LF8VUZ1372326 for ; Mon, 21 Feb 2011 15:08:31 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p1LF8MIc032121 for ; Mon, 21 Feb 2011 08:08:22 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p1LF8LXA032091; Mon, 21 Feb 2011 08:08:21 -0700 Message-Id: <201102211508.p1LF8LXA032091@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 21 Feb 2011 16:08:21 +0100 Subject: Re: [RFC, v2] ARM support for Hardware breakpoints and watchpoints for native Linux. To: uweigand@de.ibm.com (Ulrich Weigand) Date: Mon, 21 Feb 2011 15:17:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, Will.Deacon@arm.com (Will Deacon), matthew.gretton-dann@arm.com (Matthew Gretton-Dann) In-Reply-To: <201102171643.p1HGhPNF029937@d06av02.portsmouth.uk.ibm.com> from "Ulrich Weigand" at Feb 17, 2011 05:43:25 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00548.txt.bz2 > ChangeLog: > > * arm-linux-nat.c: Include "observer.h" and "gdbthread.h". > (PTRACE_GETHBPREGS, PTRACE_SETHBPREGS): Define. > (struct arm_linux_hwbp_cap): New type. > (arm_linux_get_hwbp_cap): New function. > (arm_linux_get_hw_breakpoint_count): Likewise. > (arm_linux_get_hw_watchpoint_count): Likewise. > (arm_linux_can_use_hw_breakpoint): Likewise. > (arm_hwbp_type): New type. > (arm_hwbp_control_t): Likewise. > (struct arm_linux_hw_breakpoint): Likewise. > (struct arm_linux_thread_points): Likewise. > (arm_threads): New global variable. > (arm_linux_find_breakpoints_by_tid): New function. > (arm_hwbp_control_initialize): Likewise. > (arm_hwbp_control_is_enabled): Likewise. > (arm_hwbp_control_disable): Likewise. > (arm_linux_hw_breakpoint_initialize): Likewise. > (arm_linux_get_hwbp_type): Likewise. > (arm_linux_hw_watchpoint_initialize): Likewise. > (arm_linux_hw_breakpoint_equal): Likewise. > (arm_linux_insert_hw_breakpoint1): Likewise. > (arm_linux_remove_hw_breakpoint1): Likewise. > (arm_linux_insert_hw_breakpoint): Likewise. > (arm_linux_remove_hw_breakpoint): Likewise. > (arm_linux_region_ok_for_hw_watchpoint): Likewise. > (arm_linux_insert_watchpoint): Likewise. > (arm_linux_remove_watchpoint): Likewise. > (arm_linux_stopped_data_address): Likewise. > (arm_linux_stopped_by_watchpoint): Likewise. > (arm_linux_watchpoint_addr_within_range): Likewise. > (arm_linux_new_thread): Likewise. > (arm_linux_thread_exit): Likewise. > (_initialize_arm_linux_nat): Install hardware breakpoint/watchpoint > related target callbacks. Register arm_linux_new_thread and > arm_linux_thread_exit. > * arm-tdep.h (arm_pc_is_thumb): Add prototype. > * arm-tdep.c (arm_pc_is_thumb): Make global. > (arm_gdbarch_init): Call set_gdbarch_have_nonsteppable_watchpoint. > > testsuite/ChangeLog: > > * lib/gdb.exp (skip_hw_breakpoint_tests): Add arm*-*-* target. > (skip_hw_watchpoint_tests): Likewise. > (skip_hw_watchpoint_multi_tests): Likewise. And I've checked this in as well. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com