From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1561 invoked by alias); 21 Feb 2011 08:21:39 -0000 Received: (qmail 1553 invoked by uid 22791); 21 Feb 2011 08:21:37 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Feb 2011 08:21:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CBBA02BAC46; Mon, 21 Feb 2011 03:21:29 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id n9GFgoag8iUS; Mon, 21 Feb 2011 03:21:29 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6CD122BAC2B; Mon, 21 Feb 2011 03:21:27 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B87731459B0; Mon, 21 Feb 2011 12:21:21 +0400 (RET) Date: Mon, 21 Feb 2011 09:11:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [commit/Ada] Fix unconstrained packed array size Message-ID: <20110221082121.GA2600@adacore.com> References: <1297925036-2762-1-git-send-email-brobecker@adacore.com> <20110217215803.GA30633@host1.dyn.jankratochvil.net> <20110218032426.GF15527@adacore.com> <20110218205823.GA1001@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="45Z9DzgjV8m4Oswq" Content-Disposition: inline In-Reply-To: <20110218205823.GA1001@host1.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00529.txt.bz2 --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 405 > I expected something like that. In such case there should be XFAIL (or maybe > a different pseudo-FAIL variant but XFAIL seems OK to me) like we did in: Can you try the following? Looking at the output, providing the readelf output is just going to clutter the testcase, IMO, so I left it out. The ___XA type is missing, it's not malformed, and there isn't much to add (again, IMO). Thanks, -- Joel --45Z9DzgjV8m4Oswq Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="packed-array-xfail.diff" Content-length: 1262 commit 182688b2f7709c2ea2e5963d4040aaf47b88c492 Author: Joel Brobecker Date: Mon Feb 21 12:17:39 2011 +0400 add xfail for "print u_var" test in gdb.ada/packed_array.exp gdb/testsuite/ChangeLog: * gdb.ada/packed_array.exp: Add xfail for "print u_var" if the debugger is unable to find the array bounds. diff --git a/gdb/testsuite/gdb.ada/packed_array.exp b/gdb/testsuite/gdb.ada/packed_array.exp index d7885bb..fc4dd17 100644 --- a/gdb/testsuite/gdb.ada/packed_array.exp +++ b/gdb/testsuite/gdb.ada/packed_array.exp @@ -53,6 +53,16 @@ gdb_test "print &var" \ # Print the value of U_Var, an unconstrainted packed array. -gdb_test "print u_var" \ - "= \\(true, false, false, true, true, false\\)" +set test "print u_var" +gdb_test_multiple "$test" "$test" { + -re "= \\(true, false, false, true, true, false\\)\[\r\n\]+$gdb_prompt $" { + pass $test + } + -re "= \\(warning: unable to get bounds of array.*\\)\[\r\n\]+$gdb_prompt $" { + # The compiler forgot to emit the packed array's ___XA type, + # preventing us from determining the what the array bounds + # are. Observed with (FSF GNU Ada 4.5.3 20110124). + xfail $test + } +} --45Z9DzgjV8m4Oswq--