From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: Re: RFC: move agent opcodes to common file
Date: Fri, 18 Feb 2011 19:11:00 -0000 [thread overview]
Message-ID: <201102181856.05577.pedro@codesourcery.com> (raw)
In-Reply-To: <m3ei773ae3.fsf@fleche.redhat.com>
Looks good to me.
Hmm. I think it'd be a good idea to wrap the direct accesses
to the gdb_agent_op_names array (there are a few
`gdb_agent_op_names[op]' in the code, in a function that
checks that "op" doesn't overflow the array length before
dereferencing it, and returns "?undef?" or something like that
if it does over- or underflow. It look like it'll happen if
you connect a new gdb to an older gdbserver with --debug enabled,
and send it the new opcodes.
--
Pedro Alves
next prev parent reply other threads:[~2011-02-18 18:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 22:25 Tom Tromey
2011-02-16 23:33 ` Hui Zhu
2011-02-17 2:06 ` Hui Zhu
2011-02-17 15:13 ` Tom Tromey
2011-02-18 19:11 ` Pedro Alves [this message]
2011-02-18 23:35 ` Tom Tromey
2011-02-20 15:06 ` Hui Zhu
2011-02-20 21:47 ` Pedro Alves
2011-02-21 8:17 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102181856.05577.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox