From: Joel Brobecker <brobecker@adacore.com>
To: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>,
Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] testsuite: dw2-ranges: declare function descriptors for ppc64 compatibility
Date: Thu, 17 Feb 2011 05:59:00 -0000 [thread overview]
Message-ID: <20110217054545.GA15527@adacore.com> (raw)
In-Reply-To: <1297882017-19802-1-git-send-email-emachado@linux.vnet.ibm.com>
> 2011-02-16 Edjunior Machado <emachado@br.ibm.com>
>
> gdb/
> * gdb.dwarf2/dw2-ranges.S: Add .opd section with function
> descriptors for ppc64 compatibility.
> * gdb.dwarf2/dw2-ranges2.S: Likewise.
> * gdb.dwarf2/dw2-ranges3.S: Likewise.
No objection from my end, but just some thoughts on this testcase,
aimed mostly at Jan:
- Do we really need to start the testcase at all. The comment
explains why we do this, but does this testcase in particular
bring something extra?
- Can we maybe tweak the testcase so that the main function is
written in C, rather than ASM. Then have the C function call
the old main, and the testcase run until the beginning on main.
Would things work with powerpc64 as well, if we did that?
I'm just a little concerned about polutting the essence of the
assembly file with target-specific stuff, so if we can avoid it...
--
Joel
next prev parent reply other threads:[~2011-02-17 5:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 19:31 Edjunior Barbosa Machado
2011-02-17 5:59 ` Joel Brobecker [this message]
2011-02-17 21:58 ` Jan Kratochvil
2011-02-17 22:31 ` obsolete: " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217054545.GA15527@adacore.com \
--to=brobecker@adacore.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox