From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-78323-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11494 invoked by alias); 16 Feb 2011 21:25:59 -0000
Received: (qmail 11481 invoked by uid 22791); 16 Feb 2011 21:25:58 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Feb 2011 21:25:54 +0000
Received: (qmail 24332 invoked from network); 16 Feb 2011 21:25:52 -0000
Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 16 Feb 2011 21:25:52 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Subject: Re: FYI: handle DW_OP_call_frame_cfa in AX compiler
Date: Wed, 16 Feb 2011 21:31:00 -0000
User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic; KDE/4.6.0; x86_64; ; )
Cc: gdb-patches@sourceware.org, Jan Kratochvil <jan.kratochvil@redhat.com>
References: <201102071435.20804.pedro@codesourcery.com> <m339nn6efy.fsf@fleche.redhat.com> <m3bp2b4tt1.fsf_-_@fleche.redhat.com>
In-Reply-To: <m3bp2b4tt1.fsf_-_@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201102162125.44378.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00390.txt.bz2

On Wednesday 16 February 2011 20:18:34, Tom Tromey wrote:
> Here is a patch to implement compilation of DW_OP_call_frame_cfa to
> agent expressions.
> 
> Let me know what you think.

Looks good to me.  Thanks for doing this.

OOC, why the dwarf2_compile_ftype abstraction?  Are you working
on other changes where you'll pass down something else?

> It at least let collection.exp run here.  I'll do a full regression test
> against gdbserver sometime soon.

FYI, I often do "--directory=gdb.trace" when I want a quicker sanity
check than a full testrun.  Nothing outside that directory
generates/uses axs currently.

> +	      ax_const_l (expr, - fs.regs.cfa_offset);

No space after `-'.

-- 
Pedro Alves