From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8445 invoked by alias); 16 Feb 2011 10:09:08 -0000 Received: (qmail 8435 invoked by uid 22791); 16 Feb 2011 10:09:06 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate5.uk.ibm.com (HELO mtagate5.uk.ibm.com) (194.196.100.165) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Feb 2011 10:09:01 +0000 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate5.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p1GA8w72031116 for ; Wed, 16 Feb 2011 10:08:58 GMT Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p1GA949Y1884226 for ; Wed, 16 Feb 2011 10:09:04 GMT Received: from d06av10.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p1GA8v7J020644 for ; Wed, 16 Feb 2011 03:08:57 -0700 Received: from leonard.localnet (dyn-9-152-224-51.boeblingen.de.ibm.com [9.152.224.51]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p1GA8sxc020554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 Feb 2011 03:08:57 -0700 From: Ken Werner To: "Ulrich Weigand" Subject: Re: [patch] OpenCL datatypes test fixes Date: Wed, 16 Feb 2011 10:15:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-25-generic-pae; KDE/4.5.1; i686; ; ) Cc: gdb-patches@sourceware.org References: <201102152101.p1FL1tt5009248@d06av02.portsmouth.uk.ibm.com> In-Reply-To: <201102152101.p1FL1tt5009248@d06av02.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201102161108.54061.ken@linux.vnet.ibm.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00357.txt.bz2 On Tuesday, February 15, 2011 10:01:55 pm Ulrich Weigand wrote: > Ken Werner wrote: > > -gdb_test "whatis c2" "type = char \\\[2\\\]" > > +gdb_test "whatis c2" "type = char2|char \\\[2\\\]" > > Don't we need some parentheses here (and everywere you've > introduced alternatives via |)? Otherwise, it seems that > this would stop working with the older compilers ... Hi Ulrich, Thanks for looking into this patch. Sometimes the GDB testsuite is a mystery to me. This time it seems to work without parentheses: old compiler: whatis c2 type = char [2] (gdb) PASS: gdb.opencl/datatypes.exp: whatis c2 new compiler: whatis c2 type = char2 (gdb) PASS: gdb.opencl/datatypes.exp: whatis c2 Any suggestions? Regards Ken