From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16310 invoked by alias); 16 Feb 2011 10:23:21 -0000 Received: (qmail 16301 invoked by uid 22791); 16 Feb 2011 10:23:20 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Feb 2011 10:23:15 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1GAN6Vu007520 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 Feb 2011 05:23:06 -0500 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p1GAN4NL014319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 Feb 2011 05:23:06 -0500 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p1GAN4L1028211; Wed, 16 Feb 2011 11:23:04 +0100 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id p1GAN3f9028193; Wed, 16 Feb 2011 11:23:03 +0100 Date: Wed, 16 Feb 2011 10:24:00 -0000 From: Jan Kratochvil To: Ken Werner Cc: Ulrich Weigand , gdb-patches@sourceware.org Subject: Re: [patch] OpenCL datatypes test fixes Message-ID: <20110216102302.GA22317@host1.dyn.jankratochvil.net> References: <201102152101.p1FL1tt5009248@d06av02.portsmouth.uk.ibm.com> <201102161108.54061.ken@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201102161108.54061.ken@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00359.txt.bz2 On Wed, 16 Feb 2011 11:08:54 +0100, Ken Werner wrote: > On Tuesday, February 15, 2011 10:01:55 pm Ulrich Weigand wrote: > > Ken Werner wrote: > > > -gdb_test "whatis c2" "type = char \\\[2\\\]" > > > +gdb_test "whatis c2" "type = char2|char \\\[2\\\]" > > > > Don't we need some parentheses here (and everywere you've > > introduced alternatives via |)? Otherwise, it seems that > > this would stop working with the older compilers ... > > Hi Ulrich, > > Thanks for looking into this patch. Sometimes the GDB testsuite is a mystery > to me. This time it seems to work without parentheses: > > old compiler: > whatis c2 > type = char [2] > (gdb) PASS: gdb.opencl/datatypes.exp: whatis c2 > > new compiler: > whatis c2 > type = char2 > (gdb) PASS: gdb.opencl/datatypes.exp: whatis c2 But if it prints: whatis c2 type = const char [2] it will also PASS. It should not. That is currently the line gdb_test "whatis c2" "type = char2|char \\\[2\\\]" means: gdb_test "whatis c2" "(type = char2|char \\\[2\\\])" which also means: gdb_test "whatis c2" ".*(type = char2|char \\\[2\\\])" which is not right. Thanks, Jan