Re: [rfa/rfc] Build libcommon.a for gdb and gdbserver

Tom Tromey
2011-02-18T15:52:46Z

Tom> It is vaguely bogus due to the dummy-config.h and PACKAGE_NAME
Tom> stuff. Autoconf doesn't seem to let you turn this off, and we end
Tom> up with conflicts.

Thinking about this more -- I am not so sure we should be doing any
checks in common/configure.

Right now the only source in common/ does this:

#ifdef GDBSERVER
#include "server.h"
#else
#include "defs.h"
#include "gdb_string.h"
#endif

Each branch here includes the relevant config.h from the parent project.

If common/ does its own checks then it seems like we can get into real
configure confusion: C macros defined different ways in different
places, maybe conflicting.

So I am inclined not to change my patch. I am going to check it in,
after investigating the cygnus-vs-foreign automake option.

Actually, it seems we could go a step further and just remove common's
build stuff and require the gdb and gdbserver Makefiles to build the
objects. I didn't look more deeply into this idea. If it has a
drawback, I would like to know.

Tom