From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [unavailable values part 1, 03/17] expose list of available ranges to common code
Date: Mon, 14 Feb 2011 21:44:00 -0000 [thread overview]
Message-ID: <20110214211223.GA9425@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <201102141939.10946.pedro@codesourcery.com>
On Mon, 14 Feb 2011 20:39:10 +0100, Pedro Alves wrote:
> On Monday 14 February 2011 11:59:39, Jan Kratochvil wrote:
> > > +struct mem_range
> > > +{
> > > + /* Lowest address in the range. */
> > > + CORE_ADDR start;
> > > +
> > > + /* Length of the range. */
> > > + int length;
> > > +};
> >
> > Why couldn't GDB become 64bit clean - that is CORE_ADDR length.
>
> Probably a leftover from the value ranges stuff (value lengths
> are ints, and so I made the value range lengths be ints too).
> But I disagree with making it a CORE_ADDR. I think
> lengths should be LONGEST or ULONGEST.
While ULONGEST should work due to this invariant:
ULONGEST_MAX >= CORE_ADDR_MAX
Still in which case an inferior object size does not fit in CORE_ADDR?
I do not think it can happen, CORE_ADDR should be OK for inferior size_t.
Thanks,
Jan
next prev parent reply other threads:[~2011-02-14 21:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 14:29 Pedro Alves
2011-02-14 11:59 ` Jan Kratochvil
2011-02-14 19:54 ` Pedro Alves
2011-02-14 21:44 ` Jan Kratochvil [this message]
2011-02-15 18:42 ` Tom Tromey
2011-02-15 19:14 ` Pedro Alves
2011-02-15 21:02 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110214211223.GA9425@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox