From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10683 invoked by alias); 14 Feb 2011 12:01:33 -0000 Received: (qmail 10668 invoked by uid 22791); 14 Feb 2011 12:01:32 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Feb 2011 12:01:28 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1EC1JCk025139 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 14 Feb 2011 07:01:19 -0500 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p1EC1Hog017914 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 14 Feb 2011 07:01:18 -0500 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p1EC1G2H015207; Mon, 14 Feb 2011 13:01:16 +0100 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id p1EC1GXb015109; Mon, 14 Feb 2011 13:01:16 +0100 Date: Mon, 14 Feb 2011 12:01:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [unavailable values part 1, 16/17] don't merge almost but not quite adjacent memory ranges to collect Message-ID: <20110214120116.GI2454@host1.dyn.jankratochvil.net> References: <201102071435.20804.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201102071435.20804.pedro@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00270.txt.bz2 On Mon, 07 Feb 2011 15:35:20 +0100, Pedro Alves wrote: > --- src.orig/gdb/tracepoint.c 2011-02-07 13:17:26.276706003 +0000 > +++ src/gdb/tracepoint.c 2011-02-07 13:27:53.276706002 +0000 > @@ -841,13 +841,12 @@ memrange_sortmerge (struct collection_li > { > for (a = 0, b = 1; b < memranges->next_memrange; b++) > { > - if (memranges->list[a].type == memranges->list[b].type && > - memranges->list[b].start - memranges->list[a].end <= > - MAX_REGISTER_SIZE) > + /* If memrange b overlaps or is adjacent to memrange a, > + merge them. */ > + if (memranges->list[a].type == memranges->list[b].type > + && memranges->list[b].start <= memranges->list[a].end) > { > - /* memrange b starts before memrange a ends; merge them. */ > - if (memranges->list[b].end > memranges->list[a].end) > - memranges->list[a].end = memranges->list[b].end; > + memranges->list[a].end = memranges->list[b].end; > continue; /* next b, same a */ > } > a++; /* next a */ It is an unrelated issue to this patch but this function is not a general normalizer for overlapping ranges, with bug(s) similar to normalize_mem_ranges. But maybe it does not have to be so general, all the possible contents of the tracing protocol are unknown to me. Thanks, Jan