From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [drop/fyi] About verifying record opcodes
Date: Tue, 08 Feb 2011 14:02:00 -0000 [thread overview]
Message-ID: <20110208140228.GB26412@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <AANLkTi=0TUcZ7FNKzrQrYZmDufbRJwyeUTUmO96KVzC3@mail.gmail.com>
Hi Hui,
On Tue, 08 Feb 2011 13:45:50 +0100, Hui Zhu wrote:
> That is great. Please go ahead.
Checked in.
Thanks,
Jan
http://sourceware.org/ml/gdb-cvs/2011-02/msg00044.html
--- src/gdb/ChangeLog 2011/02/08 13:58:02 1.12550
+++ src/gdb/ChangeLog 2011/02/08 14:01:47 1.12551
@@ -1,5 +1,11 @@
2011-02-08 Jan Kratochvil <jan.kratochvil@redhat.com>
+ * i386-tdep.c (i386_process_record): Rename l suffixes to d suffixes
+ in comments for pcmpgtd, pcmpeqd, psubd, paddd, pcmpgtd, pcmpeqd,
+ psubd and paddd.
+
+2011-02-08 Jan Kratochvil <jan.kratochvil@redhat.com>
+
PR 12361.
* i386-tdep.c (i386_process_record) <0x660f3807>: Fix the comment to
phsubsw.
--- src/gdb/i386-tdep.c 2011/02/08 13:58:02 1.323
+++ src/gdb/i386-tdep.c 2011/02/08 14:01:47 1.324
@@ -6347,7 +6347,7 @@
case 0x660f63: /* packsswb */
case 0x660f64: /* pcmpgtb */
case 0x660f65: /* pcmpgtw */
- case 0x660f66: /* pcmpgtl */
+ case 0x660f66: /* pcmpgtd */
case 0x660f67: /* packuswb */
case 0x660f68: /* punpckhbw */
case 0x660f69: /* punpckhwd */
@@ -6363,7 +6363,7 @@
case 0xf30f70: /* pshufhw */
case 0x660f74: /* pcmpeqb */
case 0x660f75: /* pcmpeqw */
- case 0x660f76: /* pcmpeql */
+ case 0x660f76: /* pcmpeqd */
case 0x660f7c: /* haddpd */
case 0xf20f7c: /* haddps */
case 0x660f7d: /* hsubpd */
@@ -6418,11 +6418,11 @@
case 0x660ff6: /* psadbw */
case 0x660ff8: /* psubb */
case 0x660ff9: /* psubw */
- case 0x660ffa: /* psubl */
+ case 0x660ffa: /* psubd */
case 0x660ffb: /* psubq */
case 0x660ffc: /* paddb */
case 0x660ffd: /* paddw */
- case 0x660ffe: /* paddl */
+ case 0x660ffe: /* paddd */
if (i386_record_modrm (&ir))
return -1;
ir.reg |= rex_r;
@@ -6558,7 +6558,7 @@
case 0x0f63: /* packsswb */
case 0x0f64: /* pcmpgtb */
case 0x0f65: /* pcmpgtw */
- case 0x0f66: /* pcmpgtl */
+ case 0x0f66: /* pcmpgtd */
case 0x0f67: /* packuswb */
case 0x0f68: /* punpckhbw */
case 0x0f69: /* punpckhwd */
@@ -6569,7 +6569,7 @@
case 0x0f70: /* pshufw */
case 0x0f74: /* pcmpeqb */
case 0x0f75: /* pcmpeqw */
- case 0x0f76: /* pcmpeql */
+ case 0x0f76: /* pcmpeqd */
case 0x0fc4: /* pinsrw */
case 0x0fd1: /* psrlw */
case 0x0fd2: /* psrld */
@@ -6607,11 +6607,11 @@
case 0x0ff6: /* psadbw */
case 0x0ff8: /* psubb */
case 0x0ff9: /* psubw */
- case 0x0ffa: /* psubl */
+ case 0x0ffa: /* psubd */
case 0x0ffb: /* psubq */
case 0x0ffc: /* paddb */
case 0x0ffd: /* paddw */
- case 0x0ffe: /* paddl */
+ case 0x0ffe: /* paddd */
if (i386_record_modrm (&ir))
return -1;
if (!i386_mmx_regnum_p (gdbarch, I387_MM0_REGNUM (tdep) + ir.reg))
prev parent reply other threads:[~2011-02-08 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 16:33 Jan Kratochvil
2011-02-07 15:01 ` Tom Tromey
2011-02-08 12:46 ` Hui Zhu
2011-02-08 14:02 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208140228.GB26412@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox