From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31970 invoked by alias); 6 Feb 2011 22:04:25 -0000 Received: (qmail 31961 invoked by uid 22791); 6 Feb 2011 22:04:24 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Feb 2011 22:04:20 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p16M4I01023318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 6 Feb 2011 17:04:18 -0500 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p16M4GYO021036 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 6 Feb 2011 17:04:18 -0500 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p16M4F3I031163; Sun, 6 Feb 2011 23:04:15 +0100 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id p16M4FuT031162; Sun, 6 Feb 2011 23:04:15 +0100 Date: Sun, 06 Feb 2011 22:04:00 -0000 From: Jan Kratochvil To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] c++/11734 revisited Message-ID: <20110206220414.GA31104@host1.dyn.jankratochvil.net> References: <4D002672.5090504@redhat.com> <4D07CD68.5000700@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D07CD68.5000700@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00114.txt.bz2 On Tue, 14 Dec 2010 21:02:48 +0100, Keith Seitz wrote: ... > static struct partial_symbol * > lookup_partial_symbol (struct partial_symtab *pst, const char *name, > - int global, domain_enum domain) > + int global, domain_enum domain, enum language language) > { [...] > + search_name = psymtab_search_name (name, language); > + cleanup = make_cleanup (xfree, (void *) search_name); [...] > - if (strcmp_iw_ordered (SYMBOL_SEARCH_NAME (*center), name) >= 0) > + if (strcmp_iw_ordered (SYMBOL_SEARCH_NAME (*center), > + search_name) >= 0) [...] > while (top <= real_top > - && SYMBOL_MATCHES_SEARCH_NAME (*top, name)) > + && SYMBOL_MATCHES_SEARCH_NAME (*top, search_name)) > { > if (symbol_matches_domain (SYMBOL_LANGUAGE (*top), > SYMBOL_DOMAIN (*top), domain)) > - return (*top); > + { > + do_cleanups (cleanup); > + return (*top); > + } > top++; > } > } > @@ -594,10 +657,14 @@ lookup_partial_symbol (struct partial_sy > if (symbol_matches_domain (SYMBOL_LANGUAGE (*psym), > SYMBOL_DOMAIN (*psym), domain) > && SYMBOL_MATCHES_SEARCH_NAME (*psym, name)) ^^^^ Here should be also `search_name' I think. > - return (*psym); > + { > + do_cleanups (cleanup); > + return (*psym); > + } Thanks, Jan