From: Joel Brobecker <brobecker@adacore.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA] Remove ${objdir} from test messages
Date: Sun, 06 Feb 2011 07:28:00 -0000 [thread overview]
Message-ID: <20110206071636.GO2384@adacore.com> (raw)
In-Reply-To: <1296857287.3204.10.camel@hactar>
> 2011-02-04 Thiago Jung Bauermann <bauerman@br.ibm.com>
>
> * gdb.base/break-interp.exp: Remove ${objdir} from test messages.
> * gdb.base/jit.exp: Likewise.
> * gdb.base/pie-execl.exp: Likewise.
> * gdb.base/solib-nodir.exp: Likewise.
> * gdb.base/solib-overlap.exp: Likewise.
This is OK. I would have probably done things a little differently,
as I don't think it really matters that the test label says exactly
what command was sent, as long as it's descriptive and unique. So
I would have probably chosen things like "set args $binfile_test"...
But since you've done it this way, no need to spend even more time
on this...
--
Joel
next prev parent reply other threads:[~2011-02-06 7:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 22:09 Thiago Jung Bauermann
2011-02-06 7:28 ` Joel Brobecker [this message]
2011-02-07 13:38 ` Thiago Jung Bauermann
2011-02-07 13:40 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110206071636.GO2384@adacore.com \
--to=brobecker@adacore.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox