From: Pedro Alves <pedro@codesourcery.com>
To: Daniel Jacobowitz <dan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Don't assume order of xml attributes
Date: Wed, 02 Feb 2011 17:00:00 -0000 [thread overview]
Message-ID: <201102021700.13675.pedro@codesourcery.com> (raw)
In-Reply-To: <20110202163343.GA9355@caradoc.them.org>
On Wednesday 02 February 2011 16:33:52, Daniel Jacobowitz wrote:
> This was not required. The attributes don't have to be ordered in the
> XML file, but they're ordered in the VEC because we create it that way
> in gdb_start_element. You can tell your patch still relies on this
> code because the calls to the lookup function mostly don't check for
> NULL.
Ah! Thanks for pointing it out. I completely missed it.
>
> That said, I don't think a linear search for attribute names is going
> to be too slow :-)
One would hope. :-)
> So this is a nice readability improvement anyway.
Yeah, I agree. I'll keep it in then.
Thanks,
--
Pedro Alves
prev parent reply other threads:[~2011-02-02 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 16:19 Pedro Alves
2011-02-02 16:34 ` Daniel Jacobowitz
2011-02-02 17:00 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102021700.13675.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox