From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26451 invoked by alias); 21 Jan 2011 18:58:06 -0000 Received: (qmail 26414 invoked by uid 22791); 21 Jan 2011 18:58:06 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Jan 2011 18:57:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 48CBF2BACB8 for ; Fri, 21 Jan 2011 13:57:47 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jLzoN1bH7KSZ for ; Fri, 21 Jan 2011 13:57:47 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3755E2BACB7 for ; Fri, 21 Jan 2011 13:57:47 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C926F1459AD; Fri, 21 Jan 2011 13:57:46 -0500 (EST) Date: Fri, 21 Jan 2011 19:48:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [RFA/commit/doco] move handing of "set interactive-mode" to gdb_has_a_terminal Message-ID: <20110121185746.GD2440@adacore.com> References: <1295394141-14863-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1295394141-14863-1-git-send-email-brobecker@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00445.txt.bz2 > gdb/ChangeLog: > > * inflow.c: Include "gdbcmd.h". > (interactive_mode): New static global, moved here from top.c. > (show_interactive_mode): New function, moved here from top.c. > use gdb_has_a_terminal instead of input_from_terminal_p to > determine the current mode. > (gdb_has_a_terminal): Add handling of the "iteractive-mode" > setting. > (_initialize_inflow): Add the "set/show interactive-mode" > commands. Moved here from top.c, after having adjusted slightly > the help text. > * top.c (interactive_mode, show_interactive_mode): Delete, moved > to inflow.c. > (input_from_terminal_p): Remove handling of "interactive-mode" > setting, moved to infow.c. > (init_main): Remove creation of the "set/show interactive-mode" > commands, moved to inflow.c. > > gdb/doc/ChangeLog: > > * gdb.texinfo (Other Misc Settings): Rework part of the > documentation of the "set interactive mode" command. Patch checked in with Eli's suggestions (thanks!). -- Joel