From: Ken Werner <ken@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Subject: [patch] OpenCL testsuite fix
Date: Fri, 21 Jan 2011 12:42:00 -0000 [thread overview]
Message-ID: <201101211256.18045.ken@linux.vnet.ibm.com> (raw)
[-- Attachment #1: Type: Text/Plain, Size: 293 bytes --]
Hi,
The attached patch adds the missing compile_flags argument to the
gdb_compile_opencl_hostapp call in the skip_opencl_tests procedure. This
prevents `make check` from printing error messages if there is no OpenCL
environment available (i.e. missing opencl.h).
Ok to apply?
Regards
Ken
[-- Attachment #2: opencl-testsuite.patch --]
[-- Type: text/x-patch, Size: 979 bytes --]
gdb/testsuite/ChangeLog
2011-01-21 Ken Werner <ken.werner@de.ibm.com>
* lib/opencl.exp (skip_opencl_tests): Add missing compile_flags
argument to the gdb_compile_opencl_hostapp call.
Index: gdb/testsuite/lib/opencl.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/opencl.exp,v
retrieving revision 1.1
diff -p -u -r1.1 opencl.exp
--- gdb/testsuite/lib/opencl.exp 5 Nov 2010 14:31:30 -0000 1.1
+++ gdb/testsuite/lib/opencl.exp 21 Jan 2011 11:24:30 -0000
@@ -50,7 +50,7 @@ proc skip_opencl_tests {} {
verbose "$me: compiling OpenCL test app" 2
set compile_flags {debug nowarnings quiet}
- if { [gdb_compile_opencl_hostapp "${clprogram}" "${executable}" "" ] != "" } {
+ if { [gdb_compile_opencl_hostapp "${clprogram}" "${executable}" "${compile_flags}" ] != "" } {
verbose "$me: compiling OpenCL binary failed, returning 1" 2
return [set skip_opencl_tests_saved($board) 1]
}
next reply other threads:[~2011-01-21 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 12:42 Ken Werner [this message]
2011-01-21 12:44 ` Ulrich Weigand
2011-01-21 15:13 ` Ken Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101211256.18045.ken@linux.vnet.ibm.com \
--to=ken@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox