Re: [RFC] configure.tgt: Update mips*-*-* to use remote-mips.o

[Kevin Buettner <kevinb@redhat.com>]

On Thu, 20 Jan 2011 15:51:25 +0100 (CET)
"Ulrich Weigand" <uweigand@de.ibm.com> wrote:

> Kevin Buettner wrote:
> 
> > 	* configure.tgt (mips*-*-elf): New; just like mips*-*-*, but
> > 	with remote-mips.o added to gdb_target_obs.
> 
> remote-mips.o should then also be added to ALL_TARGET_OBS in Makefile.in,
> so that it is available with --enable-targets=all builds.
> 
> Also, for some reason the ARI scripts specifically ignore remote-mips.c,
> see the gdb_find.sh script ... This probably should be removed as well if
> remote-mips.c is now regularly built.

Hi Ulrich,

Thanks for letting me know about the other files that require updating.

I've appended an updated patch below.  I did an --enable-targets=all
build to verify that the target commands implemented in remote-mips.c
are available in the resulting gdb binary.  (They are.)  I also wanted
to make sure that the build didn't blow up as a result of adding this
file.  (It didn't.)

Note the separate ChangeLog entry for the GDB admin script
gdb_find.sh.  I don't see a ChangeLog file among the admin scripts, so
I'll just use it as the commit message when I commit it.

I'll wait another day or so for further comments before committing.

Kevin

	* configure.tgt (mips*-*-elf): New; just like mips*-*-*, but
	with remote-mips.o added to gdb_target_obs.
	* Makefile.in (ALL_TARGET_OBS): Add remote-mips.o.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1146
diff -u -p -r1.1146 Makefile.in
--- Makefile.in	14 Jan 2011 13:38:23 -0000	1.1146
+++ Makefile.in	20 Jan 2011 23:22:18 -0000
@@ -554,7 +554,7 @@ ALL_TARGET_OBS = \
 	solib-frv.o solib-irix.o solib-svr4.o solib-target.o \
 	solib-som.o solib-pa64.o solib-darwin.o \
 	dbug-rom.o dink32-rom.o ppcbug-rom.o m32r-rom.o dsrec.o monitor.o \
-	remote-m32r-sdi.o \
+	remote-m32r-sdi.o remote-mips.o \
 	xcoffread.o \
 	symfile-mem.o \
 	corelow.o \
Index: configure.tgt
===================================================================
RCS file: /cvs/src/src/gdb/configure.tgt,v
retrieving revision 1.241
diff -u -p -r1.241 configure.tgt
--- configure.tgt	14 Jan 2011 18:16:34 -0000	1.241
+++ configure.tgt	20 Jan 2011 23:22:18 -0000
@@ -371,6 +371,11 @@ mips64*-*-openbsd*)
 	gdb_target_obs="mips-tdep.o mips64obsd-tdep.o \
 			corelow.o solib.o solib-svr4.o"
 	;;
+mips*-*-elf)
+	# Target: MIPS ELF
+	gdb_target_obs="mips-tdep.o remote-mips.o"
+	gdb_sim=../sim/mips/libsim.a
+	;;
 mips*-*-*)
 	# Target: MIPS
 	gdb_target_obs="mips-tdep.o"


In /cvs/gdbadmin/ss:

	* gdb_find.sh: Don't prune remote-mips.c.

Index: gdb_find.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_find.sh,v
retrieving revision 1.14
diff -u -p -r1.14 gdb_find.sh
--- gdb_find.sh	8 Oct 2009 13:07:31 -0000	1.14
+++ gdb_find.sh	20 Jan 2011 22:29:35 -0000
@@ -12,5 +12,4 @@ find "$@" \
     -name '*-exp.c' -prune -o \
     -name ada-lex.c -prune -o \
     -name cp-name-parser.c -prune -o \
-    -name remote-mips.c -prune -o \
     -type f -name '*.[lyhc]' -print | sort