From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17208 invoked by alias); 19 Jan 2011 17:12:57 -0000 Received: (qmail 17199 invoked by uid 22791); 19 Jan 2011 17:12:55 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Jan 2011 17:12:26 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A8FEC2BAC4F; Wed, 19 Jan 2011 12:12:24 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id iV1p9GiwFsVV; Wed, 19 Jan 2011 12:12:24 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A63EB2BAC3E; Wed, 19 Jan 2011 12:12:23 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 2F3FF1459AD; Wed, 19 Jan 2011 12:12:23 -0500 (EST) Date: Wed, 19 Jan 2011 17:27:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit/doco] move handing of "set interactive-mode" to gdb_has_a_terminal Message-ID: <20110119171223.GF11960@adacore.com> References: <1295394141-14863-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00400.txt.bz2 > > I feel that the name of the setting isn't great, and I've been trying > > to find better names, but not much luck (the best I have, I feel, is > > "set/show terminal-mode [on|off|auto]). > > I see nothing wrong with "set interactive-mode", maybe because I'm > accustomed to this term in Emacs. So maybe the name isn't so bad, after all. Changing it is a bit of a pain in terms of transitioning from one name to the next, so that's another argument in favor of keeping the current one. > > If @code{auto} (the default), @value{GDBN} guesses which mode to use, > > -based on whether the debugger was started in a terminal or not. > > +based on standard input settings. > > "Based on standard input settings" sounds vague and mysterious. What > exactly does this mean? Basically, we test whether stdin is a terminal or not. How about: If @code{auto} (the default), @value{GDBN} guesses which mode to use, based on whether @value{GDBN}'s standard input is a terminal. ? Thanks, -- Joel