From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16272 invoked by alias); 12 Jan 2011 21:58:07 -0000 Received: (qmail 16262 invoked by uid 22791); 12 Jan 2011 21:58:06 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Jan 2011 21:58:01 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 4840D1B404D; Wed, 12 Jan 2011 21:58:00 +0000 (UTC) From: Mike Frysinger To: Joel Brobecker Subject: Re: [PATCH] sim: check asprintf return values Date: Wed, 12 Jan 2011 22:05:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.37-rc5; KDE/4.5.2; x86_64; ; ) Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org References: <1293743311-13288-1-git-send-email-vapier@gentoo.org> <201101121306.14814.vapier@gentoo.org> <20110112212311.GG2504@adacore.com> In-Reply-To: <20110112212311.GG2504@adacore.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3495279.elPAjlzRGV"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201101121658.15838.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00283.txt.bz2 --nextPart3495279.elPAjlzRGV Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 551 On Wednesday, January 12, 2011 16:23:11 Joel Brobecker wrote: > > > * sim-module.c (sim_pre_argv_init): Return SIM_RC_FAIL when asprintf > > > fails. > > > * sim-options.c (sim_parse_args): Issue an error and return > > > SIM_RC_FAIL when asprintf fails. > > > * sim-utils.c (sim_do_commandf): Issue an error and return when > > > asprintf fails. > > > * sim-watch.c (sim_watchpoint_install): Return SIM_RC_FAIL when > > > asprintf fails. >=20 > Sorry for the delay in the review. This looks OK to me. thanks ... i've committed it then -mike --nextPart3495279.elPAjlzRGV Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iQIcBAABAgAGBQJNLiP3AAoJEEFjO5/oN/WBKa8QANm1G/wD30AblmSt32/JpBW6 3/Q6b12tCj/Z+rFDihr2b0aUD6CbEtbedajt+7z80f2jJCHKPqeRHtiigRhdTrnw Xy6r6OtURCnTkrjx+g3gOLYEWOttod+Cd3jd6PIFk9xrQ7GXKxWawPdl6aAfhsV4 htjkFU0lgC65tXfRF+S5RkbF2HDPUUXiBY1SHpRrwYp0WSUNJ8jn4NjNtYdfJEaz Oi0JwOPE4n24MwJdP7YU71U/YlWq+EEfmaPJjCqFOIKddSe4+2/fbITLnCa6gr2P aI9gtRquzaXcswuBKL8V2aTz/94HwxHE2UieSeKnebGPlGD5eF5vJktWxaF0vlWJ E9MfTxgKCepRRaD+F93xYC+Bu0YunRNxnejJBCZ2q3kxzRntqtdlCy1IG5R6zvSy OizZGCS2haL34BiVayhYlHih/U0IZkt57GNbyMqdSgySUgRIVHvPCYJC6YbPIbCH aPW91FfSMpr8yR/3fbN5lvf5ywSH67Fm7eMJYeJq8qMbSH92wAaIctlBgXnN3bzB ZAfUMAu7Ki6gW0pCToW1+ujHAmkK5NtNggQ+etYSkI/cesUOj1Ltsh3fsD47pyo3 L4vuCRixj+KhG1eP3GFiBetW4Yp32XvCRhznNDeIMdAQSEwYl0ApyHfvejw1f99X GBbL/7LtxElMiVz/efKK =yTJp -----END PGP SIGNATURE----- --nextPart3495279.elPAjlzRGV--