From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32444 invoked by alias); 11 Jan 2011 17:02:34 -0000 Received: (qmail 32417 invoked by uid 22791); 11 Jan 2011 17:02:30 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,T_FRT_PROFILE2,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Jan 2011 17:02:21 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id p0BH2JZL014284 for ; Tue, 11 Jan 2011 09:02:19 -0800 Received: from qyk12 (qyk12.prod.google.com [10.241.83.140]) by wpaz21.hot.corp.google.com with ESMTP id p0BH1JsK021872 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT) for ; Tue, 11 Jan 2011 09:02:18 -0800 Received: by qyk12 with SMTP id 12so23420422qyk.19 for ; Tue, 11 Jan 2011 09:02:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.224.64.75 with SMTP id d11mr28101106qai.214.1294765338271; Tue, 11 Jan 2011 09:02:18 -0800 (PST) Received: by 10.220.118.80 with HTTP; Tue, 11 Jan 2011 09:02:13 -0800 (PST) In-Reply-To: References: <1293426471-5571-1-git-send-email-vapier@gentoo.org> <201012280238.03847.vapier@gentoo.org> <20101228120120.GE2436@adacore.com> <201101082239.10670.vapier@gentoo.org> Date: Tue, 11 Jan 2011 17:06:00 -0000 Message-ID: Subject: Re: [toolchain-devel] [PATCH] sim: allow memory maps to default to mapped files From: Doug Evans To: Mike Frysinger Cc: toolchain-devel@blackfin.uclinux.org, gdb-patches@sourceware.org, Joel Brobecker Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00223.txt.bz2 Message-ID: <20110111170600.MnfRReRMjZO-rc6j2fHBRsEsd_lr26k3pP_1nkGodPE@z> On Tue, Jan 11, 2011 at 8:04 AM, Mike Frysinger wrote: > On Tue, Jan 11, 2011 at 10:07, Doug Evans wrote: >> On Sat, Jan 8, 2011 at 7:39 PM, Mike Frysinger wrote: >>> On Tuesday, December 28, 2010 07:01:20 Joel Brobecker wrote: >>>> OK. =A0The patch looks good to me, except for the little formatting ni= ts >>>> that I already pointed out. But can you give it a few more days for >>>> others to comment? =A0In particular, Doug Evans is more proficient with >>>> the simulator than I am, I believe (which is not hard, considering >>>> that I have barely ever touched that code). >>> >>> i'll commit in a day or two if no one has any more feedback ... >> >> Hi. =A0The only comment I have is that it would be nice to keep "struct >> stat s;" in its original location, but it's not necessary. > > i couldnt do that without duplicating the bytes and free_length setup, > and i thought not duplicating those was more important. Well, free_length can easily be moved down, it's really only bytes that's the concern. It's not worth spending time on it, but having the two ifdefs and having int a; #ifdef FOO int b; mumble #endif feels like it could be cleaner, but for this it's not worth spending time o= n.