From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5867 invoked by alias); 11 Jan 2011 00:07:43 -0000 Received: (qmail 5857 invoked by uid 22791); 11 Jan 2011 00:07:41 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Jan 2011 00:07:37 +0000 Received: (qmail 7657 invoked from network); 11 Jan 2011 00:07:35 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 11 Jan 2011 00:07:35 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: RFA: fix PR mi/8138 Date: Tue, 11 Jan 2011 00:07:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; ) Cc: Tom Tromey References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201101110007.33006.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00212.txt.bz2 On Monday 10 January 2011 20:15:56, Tom Tromey wrote: > +@table @samp > +@item from > +@itemx to > +These items, if provided, are a range of addresses belonging to this > +shared library. > +^done,sharedlibs=[lib=[from="0x00111360",to="0x00111498",syms-read="2",name="/lib/libexample.so"]] The =library-loaded event was added with the "from" and "to" fields left out on purpose. I think that this command should be consistent with the event. The event outputs both target and host paths to the shared library, this prints only a single "name". I'm not objecting, but I'm almost certain that I remember someone bringing up that this MI command was missing, but it was then mentioned that there's no real need for it since the frontend should be getting everything it needs from the =library-loaded / =library-unloaded events. (This PR predates these events by a few years). > +void > +mi_cmd_file_list_shared_libraries (char *command, char **argv, int argc) > +{ > + if (!mi_valid_noargs ("mi_cmd_file_list_shared_libraries", argc, argv)) > + error (_("mi_cmd_file_list_shared_libraries: Usage: No args")); These errors should not show GDB's function name, but instead the MI command name. We have many instances of this issue, but we have been fasing them out, and avoiding introducing new ones. -- Pedro Alves