From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20150 invoked by alias); 10 Jan 2011 23:36:35 -0000 Received: (qmail 19980 invoked by uid 22791); 10 Jan 2011 23:36:34 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Jan 2011 23:36:29 +0000 Received: (qmail 31783 invoked from network); 10 Jan 2011 23:36:26 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Jan 2011 23:36:26 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] Implement support for PowerPC BookE ranged watchpoints Date: Mon, 10 Jan 2011 23:36:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; ) Cc: Thiago Jung Bauermann References: <1294687058.3162.44.camel@hactar> In-Reply-To: <1294687058.3162.44.camel@hactar> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201101102336.24435.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00210.txt.bz2 On Monday 10 January 2011 19:17:38, Thiago Jung Bauermann wrote: > + the memory layout of a scalar type. E.g., an array or struct with only one Double space. > +static int > +resources_needed_watchpoint (const struct bp_location *bl) > +{ > + int length = bl->owner->exact? 1 : bl->length; > + > + return target_region_ok_for_hw_watchpoint (bl->address, length); > } Indenting looks wrong. Otherwise okay to commit. Thanks for persevering! I don't _think_ the target_region_ok_for_hw_watchpoint semantics change breaks any target. I dare you to implement or think about how you'd implement step 2.5 of my list with this interface. :-) You don't seem to have a way for the target to return "I can hardware assist watching this memory region, and I need exactly zero debug registers to do it." ? -- Pedro Alves