From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21404 invoked by alias); 6 Jan 2011 09:32:58 -0000 Received: (qmail 21395 invoked by uid 22791); 6 Jan 2011 09:32:57 -0000 X-SWARE-Spam-Status: No, hits=0.1 required=5.0 tests=AWL,BAYES_50,KAM_STOCKGEN X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Jan 2011 09:32:51 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7CA012BAC6B for ; Thu, 6 Jan 2011 04:32:49 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id zR7cJy98tPFA for ; Thu, 6 Jan 2011 04:32:49 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EB7642BAC6A for ; Thu, 6 Jan 2011 04:32:48 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 00C2D1459AD; Thu, 6 Jan 2011 13:32:42 +0400 (RET) Date: Thu, 06 Jan 2011 09:32:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: New ARI warning Thu Jan 6 01:53:36 UTC 2011 Message-ID: <20110106093242.GC2351@adacore.com> References: <20110106015336.GA32352@sourceware.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="DKU6Jbt7q3WqK7+M" Content-Disposition: inline In-Reply-To: <20110106015336.GA32352@sourceware.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00119.txt.bz2 --DKU6Jbt7q3WqK7+M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 290 > 521,522d520 > < gdb/linespec.c:1456: gettext: trailing new line: A message should not have a trailing new line [...] All ARI violations reported in this email should be taken care of with the attached patch. Tested on x86_64-linux (rebuilding solib-irix.c only). Checked in. -- Joel --DKU6Jbt7q3WqK7+M Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="ari-warnings.diff" Content-length: 2677 commit fd2e675aedc299242ad4d2a454e4cb60ee9ecf3c Author: Joel Brobecker Date: Thu Jan 6 13:28:41 2011 +0400 Remove trailing new-line at end of error string gdb/ChangeLog: * linespec.c (decode_compound, find_method): Remove trailing \n at end of error string. * solib-irix.c (irix_current_sos): Likewise. * varobj.c (uninstall_variable): Likewise. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 60676a3..42e77dc 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2011-01-06 Joel Brobecker + * linespec.c (decode_compound, find_method): Remove trailing \n + at end of error string. + * solib-irix.c (irix_current_sos): Likewise. + * varobj.c (uninstall_variable): Likewise. + +2011-01-06 Joel Brobecker + * copyright.py: New script. * copyright.sh (byhand): Add *.ads, *.adb, *.gpr and *.inc. Launch emacs without exec'ing. Call copyright.py afterwards. diff --git a/gdb/linespec.c b/gdb/linespec.c index dffbb36..ae48de7 100644 --- a/gdb/linespec.c +++ b/gdb/linespec.c @@ -1460,7 +1460,7 @@ decode_compound (char **argptr, int funfirstline, char ***canonical, { xfree (values.sals); error (_("the class `%s' does not have " - "any method instance named %s\n"), + "any method instance named %s"), SYMBOL_PRINT_NAME (sym_class), copy); } } @@ -1625,7 +1625,7 @@ find_method (int funfirstline, char ***canonical, char *saved_arg, } error (_("the class `%s' does not have " - "any method instance named %s\n"), + "any method instance named %s"), SYMBOL_PRINT_NAME (sym_class), copy); } diff --git a/gdb/solib-irix.c b/gdb/solib-irix.c index f233d4a..bd577a0 100644 --- a/gdb/solib-irix.c +++ b/gdb/solib-irix.c @@ -572,8 +572,8 @@ irix_current_sos (void) if (name_size >= SO_NAME_MAX_PATH_SIZE) { name_size = SO_NAME_MAX_PATH_SIZE - 1; - warning ("current_sos: truncating name of " - "%d characters to only %d characters", + warning (_("current_sos: truncating name of " + "%d characters to only %d characters"), lm.pathname_len, name_size); } diff --git a/gdb/varobj.c b/gdb/varobj.c index 8cfcccf..1792c2e 100644 --- a/gdb/varobj.c +++ b/gdb/varobj.c @@ -2060,8 +2060,8 @@ uninstall_variable (struct varobj *var) } if (cr == NULL) { - warning ("Assertion failed: Could not find " - "varobj \"%s\" in root list", + warning (_("Assertion failed: Could not find " + "varobj \"%s\" in root list"), var->obj_name); return; } --DKU6Jbt7q3WqK7+M--